Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 776243002: [turbofan] Reduce context accesses during typed lowering. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce context accesses during typed lowering. TEST=unittests R=mstarzinger@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2bf048f46cc7f7a373c63b1667018d72a56a0561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -0 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +71 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years ago (2014-12-04 10:12:18 UTC) #1
Benedikt Meurer
lgtm
6 years ago (2014-12-04 10:12:28 UTC) #2
Benedikt Meurer
PTAL
6 years ago (2014-12-04 10:12:33 UTC) #3
Michael Starzinger
LGTM.
6 years ago (2014-12-04 10:43:43 UTC) #4
Benedikt Meurer
6 years ago (2014-12-04 10:51:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bf048f46cc7f7a373c63b1667018d72a56a0561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698