sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp - Issue 776143003: Remove Isolated Worlds from Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 776143003: Remove Isolated Worlds from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp

diff --git a/sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp b/sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp

index 50157335544330507fe51211be5248bb1fea8fb9..7aa803d353b30257a5e275975cee583767831d2d 100644

--- a/sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp

+++ b/sky/engine/bindings/core/v8/custom/V8CustomEventCustom.cpp

@@ -90,8 +90,6 @@ void V8CustomEvent::initCustomEventMethodCustom(const v8::FunctionCallbackInfo<v

if (!detailsArg.IsEmpty()) {

V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::detail(info.GetIsolate()), detailsArg);

- if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())

- event->setSerializedDetail(SerializedScriptValue::createAndSwallowExceptions(detailsArg, info.GetIsolate()));

}