Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: sky/engine/bindings/core/v8/ScriptController.h

Issue 776143003: Remove Isolated Worlds from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/DOMWrapperWorld.cpp ('k') | sky/engine/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptController.h
diff --git a/sky/engine/bindings/core/v8/ScriptController.h b/sky/engine/bindings/core/v8/ScriptController.h
index 7e1bd035e6ee6a1058636ae74d9697d0b07e5808..e69bef6902642539897a8eee622580105abcb8d4 100644
--- a/sky/engine/bindings/core/v8/ScriptController.h
+++ b/sky/engine/bindings/core/v8/ScriptController.h
@@ -73,16 +73,6 @@ public:
void executeModuleScript(AbstractModule&, const String& source, const TextPosition& textPosition);
- // Executes JavaScript in an isolated world. The script gets its own global scope,
- // its own prototypes for intrinsic JavaScript objects (String, Array, and so-on),
- // and its own wrappers for all DOM nodes and DOM constructors.
- //
- // If an isolated world with the specified ID already exists, it is reused.
- // Otherwise, a new world is created.
- //
- // FIXME: Get rid of extensionGroup here.
- void executeScriptInIsolatedWorld(int worldID, const Vector<ScriptSourceCode>& sources, int extensionGroup, Vector<v8::Local<v8::Value> >* results);
-
v8::Local<v8::Value> callFunction(v8::Handle<v8::Function>, v8::Handle<v8::Value>, int argc, v8::Handle<v8::Value> argv[]);
static v8::Local<v8::Value> callFunction(ExecutionContext*, v8::Handle<v8::Function>, v8::Handle<v8::Value> receiver, int argc, v8::Handle<v8::Value> info[], v8::Isolate*);
@@ -101,7 +91,7 @@ public:
static void registerExtensionIfNeeded(v8::Extension*);
static V8Extensions& registeredExtensions();
- void setWorldDebugId(int worldId, int debuggerId);
+ void setWorldDebugId(int debuggerId);
v8::Isolate* isolate() const { return m_isolate; }
« no previous file with comments | « sky/engine/bindings/core/v8/DOMWrapperWorld.cpp ('k') | sky/engine/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698