Issue 776033002: Decompose a weird assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 776033002: Decompose a weird assert. (Closed)

Created:
6 years ago by mtklein_C

Modified:
6 years ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Decompose a weird assert. I got my hands on a list of new warnings coming out of MSVC when run with /analyze. I scanned over them and didn't see any bugs, but I did notice this is just a weird way to write this expression. (MSVC /analyze was wary of '=' in a boolean expression.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/4bfd58723b6efca37077f05c1ab92a3e85f97eb4

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/utils/SkTextureCompressor_Blitter.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776033002/1

6 years ago (2014-12-03 16:39:00 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-03 16:49:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4bfd58723b6efca37077f05c1ab92a3e85f97eb4

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages