Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: util/mach/exc_client_variants_test.cc

Issue 775943005: UniversalMachExcServer: eliminate multiple implementation inheritance (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/catch_exception_tool.cc ('k') | util/mach/exc_server_variants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exc_client_variants_test.cc
diff --git a/util/mach/exc_client_variants_test.cc b/util/mach/exc_client_variants_test.cc
index dd2036e7d2001c50f3da802d3cf601316c652891..641dcda079e7ac7f2984eff001a3f5af79f349ff 100644
--- a/util/mach/exc_client_variants_test.cc
+++ b/util/mach/exc_client_variants_test.cc
@@ -31,12 +31,12 @@ namespace crashpad {
namespace test {
namespace {
-class TestExcClientVariants : public UniversalMachExcServer,
- public MachMultiprocess {
+class TestExcClientVariants : public MachMultiprocess,
+ public UniversalMachExcServer::Interface {
public:
TestExcClientVariants(exception_behavior_t behavior, bool all_fields)
- : UniversalMachExcServer(),
- MachMultiprocess(),
+ : MachMultiprocess(),
+ UniversalMachExcServer::Interface(),
behavior_(behavior),
all_fields_(all_fields),
handled_(false) {
@@ -45,7 +45,7 @@ class TestExcClientVariants : public UniversalMachExcServer,
++exception_subcode_;
}
- // UniversalMachExcServer:
+ // UniversalMachExcServer::Interface:
virtual kern_return_t CatchMachException(
exception_behavior_t behavior,
@@ -135,8 +135,10 @@ class TestExcClientVariants : public UniversalMachExcServer,
// MachMultiprocess:
void MachMultiprocessParent() override {
+ UniversalMachExcServer universal_mach_exc_server(this);
+
kern_return_t kr =
- MachMessageServer::Run(this,
+ MachMessageServer::Run(&universal_mach_exc_server,
LocalPort(),
MACH_MSG_OPTION_NONE,
MachMessageServer::kOneShot,
« no previous file with comments | « tools/catch_exception_tool.cc ('k') | util/mach/exc_server_variants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698