Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: snapshot/mac/mach_o_image_annotations_reader_test.cc

Issue 775943005: UniversalMachExcServer: eliminate multiple implementation inheritance (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/simulate_crash_mac_test.cc ('k') | tools/catch_exception_tool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/mach_o_image_annotations_reader_test.cc
diff --git a/snapshot/mac/mach_o_image_annotations_reader_test.cc b/snapshot/mac/mach_o_image_annotations_reader_test.cc
index 60f97cc480895bbe56565aa5ce378d0634a98162..939f913f25111249068039abfe9a8f37a22d1cdb 100644
--- a/snapshot/mac/mach_o_image_annotations_reader_test.cc
+++ b/snapshot/mac/mach_o_image_annotations_reader_test.cc
@@ -43,8 +43,9 @@ namespace crashpad {
namespace test {
namespace {
-class TestMachOImageAnnotationsReader final : public MachMultiprocess,
- public UniversalMachExcServer {
+class TestMachOImageAnnotationsReader final
+ : public MachMultiprocess,
+ public UniversalMachExcServer::Interface {
public:
enum TestType {
// Don’t crash, just test the CrashpadInfo interface.
@@ -62,13 +63,13 @@ class TestMachOImageAnnotationsReader final : public MachMultiprocess,
explicit TestMachOImageAnnotationsReader(TestType test_type)
: MachMultiprocess(),
- UniversalMachExcServer(),
+ UniversalMachExcServer::Interface(),
test_type_(test_type) {
}
~TestMachOImageAnnotationsReader() {}
- // UniversalMachExcServer:
+ // UniversalMachExcServer::Interface:
kern_return_t CatchMachException(exception_behavior_t behavior,
exception_handler_t exception_port,
thread_t thread,
@@ -219,8 +220,10 @@ class TestMachOImageAnnotationsReader final : public MachMultiprocess,
if (test_type_ != kDontCrash) {
// Handle the child’s crash. Further validation will be done in
// CatchMachException().
+ UniversalMachExcServer universal_mach_exc_server(this);
+
mach_msg_return_t mr =
- MachMessageServer::Run(this,
+ MachMessageServer::Run(&universal_mach_exc_server,
LocalPort(),
MACH_MSG_OPTION_NONE,
MachMessageServer::kOneShot,
« no previous file with comments | « client/simulate_crash_mac_test.cc ('k') | tools/catch_exception_tool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698