content/common/gpu/media/dxva_video_decode_accelerator.cc - Issue 775863005: gpu: Make GPU command decoder know right format of a GPU video texture in Win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/dxva_video_decode_accelerator.cc

Issue 775863005: gpu: Make GPU command decoder know right format of a GPU video texture in Win. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TODO instead of FIXME Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/dxva_video_decode_accelerator.h ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/dxva_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/dxva_video_decode_accelerator.cc b/content/common/gpu/media/dxva_video_decode_accelerator.cc

index 5574fa7b429a8477796b4dd01242326abe272434..aaf3925a2aa308b58791346394547bb46ab69746 100644

--- a/content/common/gpu/media/dxva_video_decode_accelerator.cc

+++ b/content/common/gpu/media/dxva_video_decode_accelerator.cc

@@ -298,6 +298,7 @@ DXVAVideoDecodeAccelerator::DXVAPictureBuffer::Create(

"Failed to query ANGLE surface pointer",

linked_ptr<DXVAPictureBuffer>(NULL));

+ // TODO(dshwang): after moving to D3D11, use RGBA surface. crbug.com/438691

HRESULT hr = decoder.device_->CreateTexture(

buffer.size().width(),

buffer.size().height(),

@@ -723,6 +724,10 @@ bool DXVAVideoDecodeAccelerator::CanDecodeOnIOThread() {

return false;

}

+GLenum DXVAVideoDecodeAccelerator::GetSurfaceInternalFormat() const {

+ return GL_BGRA_EXT;

bool DXVAVideoDecodeAccelerator::InitDecoder(media::VideoCodecProfile profile) {

HMODULE decoder_dll = NULL;