gpu: Make GPU command decoder know right format of a GPU video texture in Win.

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 125 matching lines @@
   // content/common/gpu/media should implement this, and implementations in
   // other processes should not override the default implementation.
   // Returns true if VDA::Decode and VDA::Client callbacks can run on the IO
   // thread. Otherwise they will run on the GPU child thread. The purpose of
   // running Decode on the IO thread is to reduce decode latency. Note Decode
   // should return as soon as possible and not block on the IO thread. Also,
   // PictureReady should be run on the child thread if a picture is delivered
   // the first time so it can be cleared.
   virtual bool CanDecodeOnIOThread();
 
+  // Windows creates a BGRA texture.
+  // FIXME: after moving to D3D11, remove this workaround. crbug.com/438691
+  virtual unsigned GetSurfaceInternalFormat() const;

[Ken Russell (switch to Gerrit), 2014/12/08 19:52:34]

Minor note: the Google C++ style guide says to avoid using types like "unsigned"
- see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types .
Either add a comment or return int here and static_cast it to GLenum in the
implementation.

[dshwang, 2014/12/08 20:30:38]

I see. Forward declare GLenum like gles2_cmd_format.h, shader.h, and
accelerated_surface_mac.h

+
  protected:
   // Do not delete directly; use Destroy() or own it with a scoped_ptr, which
   // will Destroy() it properly by default.
   virtual ~VideoDecodeAccelerator();
 };
 
 }  // namespace media
 
 namespace base {
 
 template <class T>
 struct DefaultDeleter;
 
 // Specialize DefaultDeleter so that scoped_ptr<VideoDecodeAccelerator> always
 // uses "Destroy()" instead of trying to use the destructor.
 template <>
 struct MEDIA_EXPORT DefaultDeleter<media::VideoDecodeAccelerator> {
  public:
   void operator()(void* video_decode_accelerator) const;
 };
 
 }  // namespace base
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_