Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 775863004: Revert "[Android] Switch b/a/test_runner.py from optparse to argparse." (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
Reviewers:
perezju, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "[Android] Switch b/a/test_runner.py from optparse to argparse." This reverts commit 8a9f8022215576925f29e07f0b203cd59e4183fc. It broke tests on several bots because the list of accepted GTest suites became restricted to those included in a certain set. TBR=jbudorick@chromium.org, klundberg@chromium.org NOTRY=true BUG=438603 Committed: https://crrev.com/bd4e73d47bd0914f6bb43432efa76e90750de962 Cr-Commit-Position: refs/heads/master@{#306610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -500 lines) Patch
M build/android/pylib/base/environment_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/test_run_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/junit/setup.py View 1 chunk +2 lines, -4 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 chunk +6 lines, -6 lines 0 comments Download
M build/android/pylib/linker/setup.py View 2 chunks +4 lines, -6 lines 0 comments Download
M build/android/test_runner.py View 13 chunks +597 lines, -479 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Beverloo
+perezju for rubber stamp, mind taking a look?
6 years ago (2014-12-03 14:23:32 UTC) #2
jbudorick
lgtm
6 years ago (2014-12-03 14:26:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775863004/1
6 years ago (2014-12-03 14:29:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775863004/1
6 years ago (2014-12-03 15:46:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 15:47:45 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd4e73d47bd0914f6bb43432efa76e90750de962 Cr-Commit-Position: refs/heads/master@{#306610}
6 years ago (2014-12-03 15:48:29 UTC) #11
jam
6 years ago (2014-12-03 18:36:45 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/776973003/ by jam@chromium.org.

The reason for reverting is: this broke 8a9f8022215576925f29e07f0b203cd59e4183fc
org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizerTest#testShortSecureHTTPSUrlWithLightColors.

Powered by Google App Engine
This is Rietveld 408576698