Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 775843005: Moving member never_save_password of ManagePasswordsBubbleView to ManagePasswordsBubbleModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 8674be851ab35b5aaedf2033721a259556aacd82..92f7fee91e956338192a3dd143d8559814e39020 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -40,6 +40,10 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code when the bubble is hidden.
void OnBubbleHidden();
+ // Called by the view code when the "Never for this site." button in clicked
+ // by the user and user gets confirmation bubble.
+ void OnConfirmationForNeverForThisSite();
+
// Called by the view code when the "Nope" button in clicked by the user.
void OnNopeClicked();
@@ -47,6 +51,10 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// by the user.
void OnNeverForThisSiteClicked();
+ // Called by the view code when the "Undo" button is clicked in
+ // "Never for this site." confirmation bubble by the user.
+ void OnUndoNeverForThisSite();
+
// Called by the view code when the site is unblacklisted.
void OnUnblacklistClicked();
@@ -83,6 +91,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
return pending_credentials_;
}
const base::string16& manage_link() const { return manage_link_; }
+ bool never_save_passwords() const { return never_save_passwords_; }
const base::string16& save_confirmation_text() const {
return save_confirmation_text_;
}
@@ -119,7 +128,9 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
base::string16 manage_link_;
base::string16 save_confirmation_text_;
gfx::Range save_confirmation_link_range_;
-
+ // If true upon destruction, the user has confirmed that she never wants to
+ // save passwords for a particular site.
+ bool never_save_passwords_;
password_manager::metrics_util::UIDisplayDisposition display_disposition_;
password_manager::metrics_util::UIDismissalReason dismissal_reason_;

Powered by Google App Engine
This is Rietveld 408576698