Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 775843004: Navigation transitions (web to native app): Revert exit transition (Chrome side) (Closed)

Created:
6 years ago by Zhen Wang
Modified:
6 years ago
Reviewers:
shatch, no sievers, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Navigation transitions (web to native app): Revert exit transition (Chrome side) We need a way to revert exit transition and show hidden transition elements when coming back from native app (when back button is pressed). This is the Chrome side of the CL. Blink side CL is here: https://codereview.chromium.org/653223002/ BUG=370696 Committed: https://crrev.com/5a70789ceb6b216e0835e36d3838635f45ba3589 Cr-Commit-Position: refs/heads/master@{#307621}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : nit fix #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M content/browser/web_contents/web_contents_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Zhen Wang
Hi Simon, can you take a look before I send to Daniel and Nasko? Thanks!
6 years ago (2014-12-08 05:02:46 UTC) #2
shatch
lg2m https://codereview.chromium.org/775843004/diff/40001/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java File content/public/android/java/src/org/chromium/content_public/browser/WebContents.java (right): https://codereview.chromium.org/775843004/diff/40001/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java#newcode166 content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:166: * Revert the effect of exit transition after ...
6 years ago (2014-12-08 14:10:16 UTC) #3
Zhen Wang
Hi Daniel, can you take a look at the Java part? Hi Nasko, can you ...
6 years ago (2014-12-08 16:19:56 UTC) #5
nasko
C++ part LGTM
6 years ago (2014-12-10 00:08:55 UTC) #6
no sievers
java lgtm
6 years ago (2014-12-10 00:17:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775843004/80001
6 years ago (2014-12-10 01:44:44 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-10 02:31:20 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-10 02:32:13 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5a70789ceb6b216e0835e36d3838635f45ba3589
Cr-Commit-Position: refs/heads/master@{#307621}

Powered by Google App Engine
This is Rietveld 408576698