Add data reduction proxy debug info to net-internals#bandwidth

chrome/browser/net/chrome_network_delegate.cc

Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index ae84c3eb7eb7b887cbf8ad2baf8febf69a305fa7..b9be5e7e0f216120e7bc77ec3f24092d1edf262e 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -266,7 +266,8 @@ ChromeNetworkDelegate::ChromeNetworkDelegate(
       data_reduction_proxy_params_(NULL),
       data_reduction_proxy_usage_stats_(NULL),
       data_reduction_proxy_auth_request_handler_(NULL),
-      data_reduction_proxy_statistics_prefs_(NULL) {
+      data_reduction_proxy_statistics_prefs_(NULL),
+      data_reduction_proxy_event_store_(NULL) {
   DCHECK(enable_referrers);
   extensions_delegate_.reset(
       ChromeExtensionsNetworkDelegate::Create(event_router));
@@ -377,6 +378,24 @@ base::Value* ChromeNetworkDelegate::SessionNetworkStatsInfoToValue() const {
   return dict;
 }
 
+base::Value* ChromeNetworkDelegate::DataReductionProxyInfoToValue() const {
+  base::DictionaryValue* proxy_info_dict = new base::DictionaryValue();

[bengr, 2014/12/02 23:55:32]

proxy_info_dict -> data_reduction_proxy_info

[jeremyim, 2014/12/03 08:10:36]

Done.

+
+  if (data_reduction_proxy_enabled_) {
+    proxy_info_dict->SetString("enabled",

[bengr, 2014/12/02 23:55:32]

I prefer this slightly:

proxy_info_dict->SetString(
    "enabled",
    data_reduction_proxy_enabled_->GetValue() ? "true" : "false");

You could also do:

if (!data_reduction_proxy_enabled_)
  data_reduction_proxy_info->SetString("enabled", "unknown");
else if (data_reduction_proxy_enabled_->GetValue())
  data_reduction_proxy_info->SetString("enabled", "true");
else
  data_reduction_proxy_info->SetString("enabled", "false");

Or, if you want to be fancy (I don't like this as much):

data_reduction_proxy_info->SetString(
    "enabled",
    (data_reduction_proxy_enabled_ ?
        (data_reduction_proxy_enabled_->GetValue() ? "true" : "false") :
        "unknown");

[jeremyim, 2014/12/03 08:10:36]

Done.

+                                data_reduction_proxy_enabled_->GetValue() ?
+                                    "true" : "false");
+  } else {
+    proxy_info_dict->SetString("enabled", "unknown");
+  }
+
+  if (data_reduction_proxy_event_store_) {
+    data_reduction_proxy_event_store_->AddStoredEvents(proxy_info_dict);
+  }
+
+  return proxy_info_dict;
+}
+
 int ChromeNetworkDelegate::OnBeforeURLRequest(
     net::URLRequest* request,
     const net::CompletionCallback& callback,