Add data reduction proxy debug info to net-internals#bandwidth

chrome/browser/ui/webui/net_internals/net_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/net_internals/net_internals_ui.h"
 
 #include <algorithm>
 #include <list>
 #include <string>
 #include <utility>
@@ skipping 357 matching lines @@
   void OnHSTSQuery(const base::ListValue* list);
   void OnHSTSAdd(const base::ListValue* list);
   void OnHSTSDelete(const base::ListValue* list);
   void OnGetSessionNetworkStats(const base::ListValue* list);
   void OnCloseIdleSockets(const base::ListValue* list);
   void OnFlushSocketPools(const base::ListValue* list);
 #if defined(OS_WIN)
   void OnGetServiceProviders(const base::ListValue* list);
 #endif
   void OnSetLogLevel(const base::ListValue* list);
+  void OnGetDataReductionProxyInfo(const base::ListValue* list);
 
   // ChromeNetLog::ThreadSafeObserver implementation:
   void OnAddEntry(const net::NetLog::Entry& entry) override;
 
   // ConnectionTester::Delegate implementation:
   void OnStartConnectionTestSuite() override;
   void OnStartConnectionTestExperiment(
       const ConnectionTester::Experiment& experiment) override;
   void OnCompletedConnectionTestExperiment(
       const ConnectionTester::Experiment& experiment,
@@ skipping 183 matching lines @@
       base::Bind(&NetInternalsMessageHandler::OnGetPrerenderInfo,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "getHistoricNetworkStats",
       base::Bind(&NetInternalsMessageHandler::OnGetHistoricNetworkStats,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "getExtensionInfo",
       base::Bind(&NetInternalsMessageHandler::OnGetExtensionInfo,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "getDataReductionProxyInfo",
+      base::Bind(&IOThreadImpl::CallbackHelper,
+                 &IOThreadImpl::OnGetDataReductionProxyInfo, proxy_));
 #if defined(OS_CHROMEOS)
   web_ui()->RegisterMessageCallback(
       "refreshSystemLogs",
       base::Bind(&NetInternalsMessageHandler::OnRefreshSystemLogs,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "getSystemLog",
       base::Bind(&NetInternalsMessageHandler::OnGetSystemLog,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
@@ skipping 694 matching lines @@
     NOTREACHED();
     return;
   }
 
   DCHECK_GE(log_level, net::NetLog::LOG_ALL);
   DCHECK_LT(log_level, net::NetLog::LOG_NONE);
   net_log()->SetObserverLogLevel(
       this, static_cast<net::NetLog::LogLevel>(log_level));
 }
 
+void NetInternalsMessageHandler::IOThreadImpl::OnGetDataReductionProxyInfo(
+    const base::ListValue* list) {
+  DCHECK(!list);
+  net::HttpNetworkSession* http_network_session =
+      GetHttpNetworkSession(main_context_getter_->GetURLRequestContext());
+
+  base::Value* data_reduction_proxy_info = NULL;

[mmenke, 2014/12/03 18:58:46]

I believe nullptr is now preferred

[jeremyim, 2014/12/03 20:57:26]

Done.

+  if (http_network_session) {
+    ChromeNetworkDelegate* network_delegate =
+        static_cast<ChromeNetworkDelegate*>(
+            http_network_session->network_delegate());

[mmenke, 2014/12/03 18:58:46]

This is a problem.  See https://codereview.chromium.org/734263003/.

In general, casting is just a bad idea.

[jeremyim, 2014/12/03 20:57:26]

Yeah, I'm not too thrilled about it either, and the current implementation would
have to change based on Megan's CL (and whose CL landed first).

Some alternatives that come to mind:
- Add specific methods on NetworkDelegate for the items we are static casting
(SessionNetworkStatsInfoToValue on line 1074, DataReductionProxyInfoToValue)
which return nullptr or a null base::Value
- Add a generic "base::Value* GetCustomInfo(std::string info_type)" method on
NetworkDelegate which allows the different implementations to return their
specific information
- Some other way of plumbing DataReductionProxyEventStore here; but I'm not sure
what that would look like

+
+    if (network_delegate)
+      data_reduction_proxy_info =
+        network_delegate->DataReductionProxyInfoToValue();
+  }
+
+  SendJavascriptCommand(
+      "receivedDataReductionProxyInfo", data_reduction_proxy_info);
+}
+
 // Note that unlike other methods of IOThreadImpl, this function
 // can be called from ANY THREAD.
 void NetInternalsMessageHandler::IOThreadImpl::OnAddEntry(
     const net::NetLog::Entry& entry) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&IOThreadImpl::AddEntryToQueue, this, entry.ToValue()));
 }
 
 void NetInternalsMessageHandler::IOThreadImpl::OnStartConnectionTestSuite() {
@@ skipping 131 matching lines @@
 }
 
 NetInternalsUI::NetInternalsUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new NetInternalsMessageHandler());
 
   // Set up the chrome://net-internals/ source.
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, CreateNetInternalsHTMLSource());
 }