Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: Source/modules/device_light/DeviceLightEvent.cpp

Issue 775763007: Use event init dictionary in modules/device_light (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/device_light/DeviceLightEvent.cpp
diff --git a/Source/modules/device_light/DeviceLightEvent.cpp b/Source/modules/device_light/DeviceLightEvent.cpp
index 994629388b6a488d7451ec8564dfd62928a045a4..1bb4eec038790a3c81400acd71e0f7c00fa99145 100644
--- a/Source/modules/device_light/DeviceLightEvent.cpp
+++ b/Source/modules/device_light/DeviceLightEvent.cpp
@@ -24,8 +24,11 @@ DeviceLightEvent::DeviceLightEvent(const AtomicString& eventType, double value)
DeviceLightEvent::DeviceLightEvent(const AtomicString& eventType, const DeviceLightEventInit& initializer)
: Event(eventType, initializer)
- , m_value(initializer.value)
+ , m_value(std::numeric_limits<double>::infinity())
timvolodine 2014/12/11 18:38:46 you could do: m_value(initializer.hasValue() ? ini
bashi 2014/12/11 23:56:16 Done.
{
+ if (initializer.hasValue())
+ m_value = initializer.value();
+ setCanBubble(true);
}
const AtomicString& DeviceLightEvent::interfaceName() const

Powered by Google App Engine
This is Rietveld 408576698