 Chromium Code Reviews
 Chromium Code Reviews Issue 775763007:
  Use event init dictionary in modules/device_light  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 775763007:
  Use event init dictionary in modules/device_light  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/modules/device_light/DeviceLightEvent.cpp | 
| diff --git a/Source/modules/device_light/DeviceLightEvent.cpp b/Source/modules/device_light/DeviceLightEvent.cpp | 
| index 994629388b6a488d7451ec8564dfd62928a045a4..cb5cc9e027c7e4b8e100eb83ac414d5434e08aa9 100644 | 
| --- a/Source/modules/device_light/DeviceLightEvent.cpp | 
| +++ b/Source/modules/device_light/DeviceLightEvent.cpp | 
| @@ -24,8 +24,10 @@ DeviceLightEvent::DeviceLightEvent(const AtomicString& eventType, double value) | 
| DeviceLightEvent::DeviceLightEvent(const AtomicString& eventType, const DeviceLightEventInit& initializer) | 
| : Event(eventType, initializer) | 
| - , m_value(initializer.value) | 
| + , m_value(std::numeric_limits<double>::infinity()) | 
| 
haraken
2014/12/03 04:31:06
Doesn't this change existing behavior? I guess the
 
bashi
2014/12/03 04:36:48
This CL changes "bubbles" behavior, but doesn't ch
 
haraken
2014/12/03 04:38:36
ah, makes sense. Thanks.
 | 
| { | 
| + if (initializer.hasValue()) | 
| 
timvolodine
2014/12/03 12:37:51
is this always false now?
 | 
| + m_value = initializer.value(); | 
| 
timvolodine
2014/12/03 12:37:51
can this be initialized directly in the member ini
 | 
| } | 
| const AtomicString& DeviceLightEvent::interfaceName() const |