LayoutTests/fast/dom/DeviceLight/create-event.html - Issue 775763007: Use event init dictionary in modules/device_light

Side by Side Diff: LayoutTests/fast/dom/DeviceLight/create-event.html

Issue 775763007: Use event init dictionary in modules/device_light (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <script>	5 <script>

6 description("Tests that document.createEvent() works with DeviceLightEvent.");	6 description("Tests that document.createEvent() works with DeviceLightEvent.");

7	7

8 var event = document.createEvent('DeviceLightEvent');	8 var event = document.createEvent('DeviceLightEvent');

9 var newEvent = new DeviceLightEvent("devicelight", {	9 var newEvent = new DeviceLightEvent("devicelight", {

10 bubbles: true, cancelable: false,	10 bubbles: true, cancelable: false,

(...skipping 13 matching lines...) Expand all Loading...
24	24

25 shouldBeTrue("typeof newEvent.type == 'string'");	25 shouldBeTrue("typeof newEvent.type == 'string'");

26 shouldBeEqualToString("newEvent.type", "devicelight");	26 shouldBeEqualToString("newEvent.type", "devicelight");

27 shouldBeTrue("typeof newEvent.bubbles == 'boolean'");	27 shouldBeTrue("typeof newEvent.bubbles == 'boolean'");

28 shouldBeTrue("newEvent.bubbles");	28 shouldBeTrue("newEvent.bubbles");

29 shouldBeTrue("typeof newEvent.cancelable == 'boolean'");	29 shouldBeTrue("typeof newEvent.cancelable == 'boolean'");

30 shouldBeFalse("newEvent.cancelable")	30 shouldBeFalse("newEvent.cancelable")

31 shouldBeTrue("typeof newEvent.value == 'number'");	31 shouldBeTrue("typeof newEvent.value == 'number'");

32 shouldBeEqualToNumber('newEvent.value', 10);	32 shouldBeEqualToNumber('newEvent.value', 10);

33	33

34 shouldBeTrue("defaultEvent.bubbles");	34 shouldBeFalse("defaultEvent.bubbles");
	timvolodine 2014/12/03 12:37:50 unless I am missing something the spec explicitly unless I am missing something the spec explicitly states that the event should bubble, see http://w3c.github.io/ambient-light/.. bashi 2014/12/04 23:40:52 It seems that I forgot to put a comment to describ Show quoted text On 2014/12/03 12:37:50, timvolodine wrote: > unless I am missing something the spec explicitly states that the event should > bubble, see http://w3c.github.io/ambient-light/.. It seems that I forgot to put a comment to describe this change (I wrote it in the initial PS, but deleted it before actual review). Sorry for the confusion. I think it should be configurable by scripts, as all other interfaces which inherit from Event allow to do so. The spec says: "When a user agent is required to fire a device light event, the user agent must run the following steps: 1. Create an event that uses the DeviceLightEvent interface, with the name devicelight, which bubbles, is not cancelable, and has no default action, that also meets the following conditions ..." However, EventInits are used by scripts(not UA), and they should be able to control 'bubbles' and 'cancelable'. Note that you can force DeviceEvent's bubbles always to be true when you create it in Blink, with DeviceEventInit.bubbles = true, or by calling another constructor. If the spec really wants to make the event's bubbles be always true, I'll revise the CL. timvolodine 2014/12/09 14:49:29 I did not write the spec :/, I was looking at http Show quoted text On 2014/12/04 23:40:52, bashi1 wrote: > On 2014/12/03 12:37:50, timvolodine wrote: > > unless I am missing something the spec explicitly states that the event should > > bubble, see http://w3c.github.io/ambient-light/.. > > It seems that I forgot to put a comment to describe this change (I wrote it in > the initial PS, but deleted it before actual review). Sorry for the confusion. > > I think it should be configurable by scripts, as all other interfaces which > inherit from Event allow to do so. > > The spec says: > > "When a user agent is required to fire a device light event, the user agent must > run the following steps: > > 1. Create an event that uses the DeviceLightEvent interface, with the name > devicelight, which bubbles, is not cancelable, and has no default action, that > also meets the following conditions ..." > > However, EventInits are used by scripts(not UA), and they should be able to > control 'bubbles' and 'cancelable'. Note that you can force DeviceEvent's > bubbles always to be true when you create it in Blink, with > DeviceEventInit.bubbles = true, or by calling another constructor. > > If the spec really wants to make the event's bubbles be always true, I'll revise > the CL. I did not write the spec :/, I was looking at http://w3c.github.io/ambient-light/#idl-def-DeviceLightEvent. so according to that bubbles should be true. you can contact the authors if in doubt: Anssi Kostiainen who is at intel would be a good guess I think. btw a developer who implemented Device Light API is one of the reviewers: riju_@ what do you think? bashi 2014/12/10 00:06:06 Hmm, my point was "a user agent" is different from Show quoted text On 2014/12/09 14:49:29, timvolodine wrote: > On 2014/12/04 23:40:52, bashi1 wrote: > > On 2014/12/03 12:37:50, timvolodine wrote: > > > unless I am missing something the spec explicitly states that the event > should > > > bubble, see http://w3c.github.io/ambient-light/.. > > > > It seems that I forgot to put a comment to describe this change (I wrote it in > > the initial PS, but deleted it before actual review). Sorry for the confusion. > > > > I think it should be configurable by scripts, as all other interfaces which > > inherit from Event allow to do so. > > > > The spec says: > > > > "When a user agent is required to fire a device light event, the user agent > must > > run the following steps: > > > > 1. Create an event that uses the DeviceLightEvent interface, with the name > > devicelight, which bubbles, is not cancelable, and has no default action, that > > also meets the following conditions ..." > > > > However, EventInits are used by scripts(not UA), and they should be able to > > control 'bubbles' and 'cancelable'. Note that you can force DeviceEvent's > > bubbles always to be true when you create it in Blink, with > > DeviceEventInit.bubbles = true, or by calling another constructor. > > > > If the spec really wants to make the event's bubbles be always true, I'll > revise > > the CL. > > I did not write the spec :/, I was looking at > http://w3c.github.io/ambient-light/#idl-def-DeviceLightEvent. > so according to that bubbles should be true. > > you can contact the authors if in doubt: Anssi Kostiainen who is at intel would > be a good guess I think. btw a developer who implemented Device Light API is one > of the reviewers: > riju_@ what do you think? Hmm, my point was "a user agent" is different from "scripts". It seems that it would be better to keep the behavior, so I revised the CL. Could you take another look? Thanks!
35 shouldBeFalse("defaultEvent.cancelable");	35 shouldBeFalse("defaultEvent.cancelable");

36 </script>	36 </script>

37 </body>	37 </body>

38 </html>	38 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/DeviceLight/create-event-expected.txt » ('j') | Source/modules/device_light/DeviceLightEvent.cpp » ('J')