Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 775733002: Disable Express path for Windows toolchain, and point to instructions (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Disable Express path for Windows toolchain, and point to instructions This could be simplified a bunch more, but this path was already non-functional and tries to download Express which is a waste of time and confusing for people. R=dpranke@chromium.org BUG=433551 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293199

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scottmg
6 years ago (2014-12-02 18:52:49 UTC) #1
Dirk Pranke
lgtm
6 years ago (2014-12-02 18:54:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775733002/1
6 years ago (2014-12-02 19:00:47 UTC) #4
commit-bot: I haz the power
Presubmit check for 775733002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-02 19:02:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775733002/20001
6 years ago (2014-12-02 19:08:48 UTC) #8
commit-bot: I haz the power
Presubmit check for 775733002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-02 19:10:46 UTC) #10
scottmg
6 years ago (2014-12-02 21:20:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 293199.

Powered by Google App Engine
This is Rietveld 408576698