Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 775663002: Revert of cc: Added RED_8 to the ResourceFormat enum (Closed)

Created:
6 years ago by pkotwicz
Modified:
6 years ago
Reviewers:
danakj, hendrikw, reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Added RED_8 to the ResourceFormat enum (patchset #2 id:20001 of https://codereview.chromium.org/735493003/) Reason for revert: Reverting the CL because it broke the CrOS ozone compile. See http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/7795/steps/compile/logs/stdio Original issue's description: > cc: Added RED_8 to the ResourceFormat enum > > New ResourceFormat, RED_8, which translates to GL_UNSIGNED_BYTE on format > GL_RED_EXT. This will be used during YUV playback. > > At the moment nothing uses it. > > BUG=435379 > > Committed: https://crrev.com/7550d17cfdab5d173f37e5b58cbd2cfeef3d0ed0 > Cr-Commit-Position: refs/heads/master@{#306383} TBR=vmpstr@chromium.org,danakj@chromium.org,reveman@chromium.org,hendrikw@chromium.org NOTREECHECKS=true NOTRY=true BUG=435379 Committed: https://crrev.com/5ea1c62009f7b0cc4d4de39cca196fb6a65c8015 Cr-Commit-Position: refs/heads/master@{#306384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -41 lines) Patch
M cc/resources/raster_worker_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_format.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/resource_format.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_provider.h View 3 chunks +14 lines, -17 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/texture_uploader_unittest.cc View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Created Revert of cc: Added RED_8 to the ResourceFormat enum
6 years ago (2014-12-02 15:12:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775663002/1
6 years ago (2014-12-02 15:13:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 15:14:09 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-02 15:14:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ea1c62009f7b0cc4d4de39cca196fb6a65c8015
Cr-Commit-Position: refs/heads/master@{#306384}

Powered by Google App Engine
This is Rietveld 408576698