Improve documentation for special-purpose policy providers.

components/policy/core/common/proxy_policy_provider.h

Index: components/policy/core/common/proxy_policy_provider.h
diff --git a/components/policy/core/common/proxy_policy_provider.h b/components/policy/core/common/proxy_policy_provider.h
index 080952210cf86e3b1134afca6f5c09f709b789c1..2a05612b30ed91d9d80b13e78131cf674bbb6c8d 100644
--- a/components/policy/core/common/proxy_policy_provider.h
+++ b/components/policy/core/common/proxy_policy_provider.h
@@ -13,6 +13,29 @@ namespace policy {
 
 // A policy provider implementation that acts as a proxy for another policy
 // provider, swappable at any point.
+//
+// Note that ProxyPolicyProvider correctly forwards RefreshPolicies() calls to
+// the delegate if present. If there is no delegate, the refresh results in an
+// immediate (empty) policy update.
+//
+// Furthermore, IsInitializationComplete is implemented trivially - it always

[Andrew T Wilson (Slow), 2014/12/05 15:21:04]

nit: IsInitializationComplete() to match the rest of the comment that include ()
for functions.

[Mattias Nissler (ping if slow), 2014/12/05 15:24:49]

Done.

+// returns true. Given that the delegate may be swapped at any point, there's no
+// point in trying to carry over initialization status from the delegate.
+//
+// This policy provider implementation is used to inject browser-global policy
+// originating from the user policy configured on the primary Chrome OS user
+// (i.e. the user logging in from the login screen). This way, policy settings
+// on the primary user propagate into g_browser_process->local_state_().
+//
+// The bizarre situation of user-scoped policy settings which are implemented
+// browser-global wouldn't exist in an ideal world. However, for historic
+// and technical reasons there are policy settings that are scoped to the user
+// but are implemented to take effect for the entire browser instance. A good
+// example for this are policies that affect the Chrome network stack in areas
+// where there's no profile-specific context. The meta data in
+// policy_templates.json allows to identify the policies in this bucket; they'll
+// have per_profile set to False, supported_on including chrome_os, and
+// dynamic_refresh set to True.
 class POLICY_EXPORT ProxyPolicyProvider
     : public ConfigurationPolicyProvider,
       public ConfigurationPolicyProvider::Observer {