Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 775613004: Improve documentation for special-purpose policy providers. (Closed)

Created:
6 years ago by Mattias Nissler (ping if slow)
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_provider_dcheck
Project:
chromium
Visibility:
Public.

Description

Improve documentation for special-purpose policy providers. ProxyPolicyProvider and ForwardingPolicyProvider seemed to be similar-purpose judging by the name, but that's far from accurate. This change adds more documentation and renames ForwardingPolicyProvider to SchemaRegistryTrackingPolicyProvider in an attempt to clarify the situation for readers coming after me. BUG=None TEST=No functional changes. Committed: https://crrev.com/050d7d754b374a4d0828aec1ab49d524c5f67ce5 Cr-Commit-Position: refs/heads/master@{#307028}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits. #

Messages

Total messages: 9 (2 generated)
Mattias Nissler (ping if slow)
Not sure whether Joao is still taking reviews, so adding the two of you :)
6 years ago (2014-12-05 15:11:50 UTC) #2
Andrew T Wilson (Slow)
lgtm, assuming there are no differences between the two new files and the deleted forwarding_* ...
6 years ago (2014-12-05 15:21:04 UTC) #3
Mattias Nissler (ping if slow)
Thanks for reviewing. The other changes are indeed just text replacements and subsequent reformatting where ...
6 years ago (2014-12-05 15:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775613004/20001
6 years ago (2014-12-05 15:25:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 16:15:21 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/050d7d754b374a4d0828aec1ab49d524c5f67ce5 Cr-Commit-Position: refs/heads/master@{#307028}
6 years ago (2014-12-05 16:16:06 UTC) #8
Joao da Silva
6 years ago (2014-12-08 11:10:18 UTC) #9
Message was sent while issue was closed.
Belated lgtm

Powered by Google App Engine
This is Rietveld 408576698