Experimental app list: Fixed failing browser tests.

Experimental app list: Fixed failing browser tests.

These tests pass on TOT, but if you switch on the
--enable-experimental-app-list flag, 3 browser tests fail.

Fixed ShelfAppBrowserTest.ClickView / BasicDragAndDrop: Click the "All
Apps" button before testing interaction with the apps grid view.

Fixed ShelfAppBrowserTestWithMultiMonitor.BasicDragAndDrop: Increase the
screen resolution so the app list does not cover the shelf; fixed tile
rect offset to take padding into account.

Fixed AppListControllerSearchResultsBrowserTest.UninstallSearchResult:
This test fails (legitimately) in the experimental app list. Force it to
run in the classic app list. Filed crbug.com/438119 to fix it properly.

BUG=438115
Committed: https://crrev.com/4d8c2955233fff8b7e608857be65ec95254591fa
Cr-Commit-Position: refs/heads/master@{#306551}

[Matt Giuca, 2014-12-02 07:31:30]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org, derat@chromium.org

[Matt Giuca, 2014-12-02 07:31:31]

derat: Please review ash/, chrome/browser/ui/ash/.
calamity: Please review chrome/browser/ui/app_list/.

Relevant info about the --enable-experimental-app-list flag:
1. The app list is much bigger (hence I had to change the resolution; otherwise
the app list would cover the shelf and the test dragging an item onto the shelf
would fail).
2. It opens to a "start page", not directly to the apps grid. So you have to
click the "all apps" button to get to the apps grid that the test is expecting
to interact with.
3. It has padding between the app list items, so it is not valid to simply add
an item's height to get the second row's Y coordinate.

[Daniel Erat, 2014-12-02 15:09:57]

lgtm for my part

https://codereview.chromium.org/775553003/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
(right):

https://codereview.chromium.org/775553003/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:134:
all_apps_rect.CenterPoint().y());
nit: fix indenting

[Matt Giuca, 2014-12-03 00:47:50]

https://codereview.chromium.org/775553003/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
(right):

https://codereview.chromium.org/775553003/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:134:
all_apps_rect.CenterPoint().y());
On 2014/12/02 15:09:57, Daniel Erat wrote:
> nit: fix indenting

Done.

[calamity, 2014-12-03 03:39:41]

lgtm

https://codereview.chromium.org/775553003/diff/20001/chrome/browser/ui/ash/la...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
(right):

https://codereview.chromium.org/775553003/diff/20001/chrome/browser/ui/ash/la...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:118:
void OnStartPageClickAllAppsButton(ui::test::EventGenerator* generator,
This name is confusing and sounds like an event.

[Matt Giuca, 2014-12-03 03:42:43]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2014-12-03 03:44:02]

https://codereview.chromium.org/775553003/diff/20001/chrome/browser/ui/ash/la...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
(right):

https://codereview.chromium.org/775553003/diff/20001/chrome/browser/ui/ash/la...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:118:
void OnStartPageClickAllAppsButton(ui::test::EventGenerator* generator,
On 2014/12/03 03:39:41, calamity wrote:
> This name is confusing and sounds like an event.

Done.

[Matt Giuca, 2014-12-03 03:44:05]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-12-03 03:44:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775553003/40001

[commit-bot: I haz the power, 2014-12-03 04:35:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-03 04:35:51]

Patchset 3 (id:??) landed as
https://crrev.com/4d8c2955233fff8b7e608857be65ec95254591fa
Cr-Commit-Position: refs/heads/master@{#306551}