Issue 775543003: Fix FilesystemUtils.SourceDirForPath after r306368

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 775543003: Fix FilesystemUtils.SourceDirForPath after r306368 (Closed)

Created:
6 years ago by scottmg

Modified:
6 years ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix FilesystemUtils.SourceDirForPath after r306368 TBR=brettw@chromium.org BUG=348474 Committed: https://chromium.googlesource.com/chromium/src/+/9a760d92ae2316c12009938fa88021a6be726bb8

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gn/filesystem_utils_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scottmg

I'm not quite sure what happened, I guess we don't gn_unittests on trybots though.

6 years ago (2014-12-02 21:45:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775543003/1

6 years ago (2014-12-02 21:58:40 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9a760d92ae2316c12009938fa88021a6be726bb8 Cr-Commit-Position: refs/heads/master@{#306471}

6 years ago (2014-12-02 22:14:11 UTC) #4

scottmg

Committed patchset #1 (id:1) manually as 9a760d92ae2316c12009938fa88021a6be726bb8 (presubmit successful).

6 years ago (2014-12-02 22:14:17 UTC) #5

brettw

6 years ago (2014-12-02 22:58:00 UTC) #6

Message was sent while issue was closed.

LGTM. No, we don't run the tests automatically. I started doing this but it
required some rejiggering of test harnesses since GN uses the "simple" one
(which runs faster in our case) but the bots expect the complicated multiprocess
one (uglier and slower for this test).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages