Limit the heading level to 1 - 9.

Limit the heading level to 1 - 9.

According to http://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaLevel
when aria-level is used on heading role then UIA supports up to heading level 9.

<h2 aria-level="9">Level 9</h2>
<h1 aria-level="20">Level 1</h1>

AX Tree:
IA2_ROLE_HEADING level:9
IA2_ROLE_HEADING level:1

BUG=365082
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186567

[shreeramk, 2014-12-02 06:06:05]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-12-02 06:06:06]

Please review.

Thanks!!!

[dmazzoni, 2014-12-04 08:26:32]

https://codereview.chromium.org/775533002/diff/1/Source/modules/accessibility...
File Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/775533002/diff/1/Source/modules/accessibility...
Source/modules/accessibility/AXNodeObject.cpp:882: &&
getAttribute(aria_levelAttr).toInt() <= 9)
This still allows 0 and negative numbers. I'd assert that it's >= 1 also.

Might be good to put getAttribute inside a block and only call it once:

    if (roleValue() == HeadingRole && hasAttribute(aria_levelAttr)) {
        int level = getAttribute(aria_levelAttr).toInt();
        if (level >= 1 && level <= 9)
            return level;
    }

[shreeramk, 2014-12-04 16:57:48]

Comments incorporated. PTAL.

Thanks!!

[dmazzoni, 2014-12-05 04:51:31]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-12-05 04:51:32]

lgtm

Thanks!

[commit-bot: I haz the power, 2014-12-05 04:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775533002/20001

[commit-bot: I haz the power, 2014-12-05 05:35:20]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186567

[dominicc (has gone to gerrit), 2014-12-05 06:15:24]

On 2014/12/05 05:35:20, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=186567

Why doesn't this change have tests?

[shreeramk, 2014-12-05 06:19:44]

On 2014/12/05 06:15:24, dominicc wrote:
> On 2014/12/05 05:35:20, I haz the power (commit-bot) wrote:
> > Committed patchset #2 (id:20001) as
> > https://src.chromium.org/viewvc/blink?view=rev&revision=186567
> 
> Why doesn't this change have tests?

For this test would be submitted in chromium side.

Here is that CL https://codereview.chromium.org/769783002/