Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 77553005: Convert constant numbers at compile time. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Convert constant numbers at compile time. TEST=mjsunit/number-tostring R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17917

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/hydrogen.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Hey Michael, Here's the next constant optimization. PTAL -- Benedikt
7 years, 1 month ago (2013-11-20 10:36:38 UTC) #1
mvstanton
One question for ya below. https://codereview.chromium.org/77553005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/77553005/diff/1/src/hydrogen.cc#newcode1545 src/hydrogen.cc:1545: if (object->IsConstant()) { I ...
7 years, 1 month ago (2013-11-20 11:49:39 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/77553005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/77553005/diff/1/src/hydrogen.cc#newcode1545 src/hydrogen.cc:1545: if (object->IsConstant()) { On 2013/11/20 11:49:40, mvstanton wrote: > ...
7 years, 1 month ago (2013-11-20 11:56:45 UTC) #3
mvstanton
lgtm
7 years, 1 month ago (2013-11-20 12:27:46 UTC) #4
Benedikt Meurer
7 years, 1 month ago (2013-11-20 12:35:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17917.

Powered by Google App Engine
This is Rietveld 408576698