Source/core/html/track/vtt/VTTParser.cpp - Issue 77553004: Defer setting type in the WebVTT tokenizer until emitting the token

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTParser.cpp

Issue 77553004: Defer setting type in the WebVTT tokenizer until emitting the token (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/timestamps-expected.txt ('k') | Source/core/html/track/vtt/VTTToken.h » ('j') | Source/core/html/track/vtt/VTTToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/track/vtt/VTTParser.cpp

diff --git a/Source/core/html/track/vtt/VTTParser.cpp b/Source/core/html/track/vtt/VTTParser.cpp

index 64c6929544cb81e2d1d080086dda3ba4f46f9785..77e314a733f07acf3ec2a0c8e2e8a8feb06c5114 100644

--- a/Source/core/html/track/vtt/VTTParser.cpp

+++ b/Source/core/html/track/vtt/VTTParser.cpp

@@ -385,12 +385,11 @@ PassRefPtr<DocumentFragment> VTTTreeBuilder::buildFromString(const String& cueTe

m_currentNode = fragment;

- OwnPtr<VTTTokenizer> tokenizer(VTTTokenizer::create());

+ VTTTokenizer tokenizer(cueText);

m_token.clear();

m_languageStack.clear();

- SegmentedString content(cueText);

- while (tokenizer->nextToken(content, m_token))

+ while (tokenizer.nextToken(m_token))

constructTreeFromToken(m_document);

return fragment.release();