Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: cc/resources/picture_layer_tiling_perftest.cc

Issue 775483002: cc: Remove max tiles and skewport constants from tiling client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/picture_layer_tiling_perftest.cc
diff --git a/cc/resources/picture_layer_tiling_perftest.cc b/cc/resources/picture_layer_tiling_perftest.cc
index 3944e4698dc92fa6a4144d04083ff3402ad64f49..e5445c7e17734e968c0c7e0e4101f4b50cb68bcb 100644
--- a/cc/resources/picture_layer_tiling_perftest.cc
+++ b/cc/resources/picture_layer_tiling_perftest.cc
@@ -23,6 +23,10 @@ static const int kTimeLimitMillis = 2000;
static const int kWarmupRuns = 5;
static const int kTimeCheckInterval = 10;
+const size_t kMaxTilesForInterestArea = 250;
danakj 2014/12/02 21:58:37 Maybe these should be defaults in LayerTreeSetting
+const float kSkewportTargetTimeInSeconds = 1.0f;
+const int kSkewportExtrapolationLimitInContentPixels = 2000;
+
class PictureLayerTilingPerfTest : public testing::Test {
public:
PictureLayerTilingPerfTest()
@@ -45,10 +49,11 @@ class PictureLayerTilingPerfTest : public testing::Test {
void SetUp() override {
picture_layer_tiling_client_.SetTileSize(gfx::Size(256, 256));
- picture_layer_tiling_client_.set_max_tiles_for_interest_area(250);
picture_layer_tiling_client_.set_tree(PENDING_TREE);
picture_layer_tiling_ = PictureLayerTiling::Create(
- 1, gfx::Size(256 * 50, 256 * 50), &picture_layer_tiling_client_);
+ 1, gfx::Size(256 * 50, 256 * 50), &picture_layer_tiling_client_,
+ kMaxTilesForInterestArea, kSkewportTargetTimeInSeconds,
+ kSkewportExtrapolationLimitInContentPixels);
picture_layer_tiling_->CreateAllTilesForTesting();
}
@@ -126,8 +131,10 @@ class PictureLayerTilingPerfTest : public testing::Test {
void RunRasterIteratorConstructTest(const std::string& test_name,
const gfx::Rect& viewport) {
gfx::Size bounds(viewport.size());
- picture_layer_tiling_ =
- PictureLayerTiling::Create(1, bounds, &picture_layer_tiling_client_);
+ picture_layer_tiling_ = PictureLayerTiling::Create(
+ 1, bounds, &picture_layer_tiling_client_, kMaxTilesForInterestArea,
+ kSkewportTargetTimeInSeconds,
+ kSkewportExtrapolationLimitInContentPixels);
picture_layer_tiling_client_.set_tree(ACTIVE_TREE);
picture_layer_tiling_->ComputeTilePriorityRects(viewport, 1.0f, 1.0,
Occlusion());
@@ -151,8 +158,10 @@ class PictureLayerTilingPerfTest : public testing::Test {
int num_tiles,
const gfx::Rect& viewport) {
gfx::Size bounds(10000, 10000);
- picture_layer_tiling_ =
- PictureLayerTiling::Create(1, bounds, &picture_layer_tiling_client_);
+ picture_layer_tiling_ = PictureLayerTiling::Create(
+ 1, bounds, &picture_layer_tiling_client_, kMaxTilesForInterestArea,
+ kSkewportTargetTimeInSeconds,
+ kSkewportExtrapolationLimitInContentPixels);
picture_layer_tiling_client_.set_tree(ACTIVE_TREE);
picture_layer_tiling_->ComputeTilePriorityRects(viewport, 1.0f, 1.0,
Occlusion());

Powered by Google App Engine
This is Rietveld 408576698