cc: Remove max tiles and skewport constants from tiling client.

cc/layers/picture_layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 
@@ skipping 580 matching lines @@
 void PictureLayerImpl::DidBecomeActive() {
   LayerImpl::DidBecomeActive();
   // TODO(vmpstr): See if this can be removed in favour of calling it from LTHI
   layer_tree_impl()->DidModifyTilePriorities();
 }
 
 void PictureLayerImpl::DidBeginTracing() {
   raster_source_->DidBeginTracing();
 }
 
+void PictureLayerImpl::ResetTileCache() {
+  RemoveAllTilings();
+  if (!tilings_)
+    return;
+
+  // Reset the settings.
+  // TODO(vmpstr): Should this funciton set tilings_ to nullptr instead?

[enne (OOO), 2014/12/02 21:25:58]

I'm not sure.  I think previously PictureLayerImpl has just tried to always
assume tilings_ was not null, but maybe if it was more explicit about when it
could be null and when it got lazily created then this could be clearer? I'm not
100% what all the details of how this would look.

[danakj, 2014/12/02 21:58:37]

I'd like to not deal with nullptrs. With my CL it's always non-null and that
seems nice. It could even change to a non-pointer member perhaps.

I'm a bit surprised this function doesn't do tilings_ = PLTS::Create(... all
these new values ...), then you don't need setters. Given that it's a scoped_ptr
right now. How come it doesn't just recreate tilings_?

Maybe this class could have a method (or static file method) that creates a PLTS
and takes a LTI* as a parameter to look up stuff. And PLI could use that method
to reset the PLTS here and in the other creation location?

+  tilings_->SetMaxTilesForInterestArea(GetMaxTilesForInterestArea());
+  tilings_->SetSkewportTargetTimeInSeconds(GetSkewportTargetTimeInSeconds());
+  tilings_->SetSkewportExtrapolationLimitInContentPixels(
+      GetSkewportExtrapolationLimitInContentPixels());
+}
+
 void PictureLayerImpl::ReleaseResources() {
-  if (tilings_)
-    RemoveAllTilings();
-
-  ResetRasterScale();
+  ResetTileCache();
 
   // To avoid an edge case after lost context where the tree is up to date but
   // the tilings have not been managed, request an update draw properties
   // to force tilings to get managed.
   layer_tree_impl()->set_needs_update_draw_properties();
 }
 
 skia::RefPtr<SkPicture> PictureLayerImpl::GetPicture() {
   return raster_source_->GetFlattenedPicture();
 }
@@ skipping 242 matching lines @@
   }
 
   *resource_id = draw_info.get_resource_id();
   *resource_size = iter.texture_size();
 }
 
 void PictureLayerImpl::DoPostCommitInitialization() {
   DCHECK(needs_post_commit_initialization_);
   DCHECK(layer_tree_impl()->IsPendingTree());
 
-  if (!tilings_)
-    tilings_ = PictureLayerTilingSet::Create(this);
+  if (!tilings_) {
+    tilings_ = PictureLayerTilingSet::Create(
+        this, GetMaxTilesForInterestArea(), GetSkewportTargetTimeInSeconds(),
+        GetSkewportExtrapolationLimitInContentPixels());
+  }
 
   PictureLayerImpl* twin_layer = GetPendingOrActiveTwinLayer();
   if (twin_layer) {
     // If the twin has never been pushed to, do not sync from it.
     // This can happen if this function is called during activation.
     if (!twin_layer->needs_post_commit_initialization_)
       SyncFromActiveLayer(twin_layer);
   }
 
   needs_post_commit_initialization_ = false;
@@ skipping 597 matching lines @@
     IteratorType index = stages_[current_stage_].iterator_type;
     TilePriority::PriorityBin tile_type = stages_[current_stage_].tile_type;
 
     if (iterators_[index] && iterators_[index].get_type() == tile_type)
       break;
     ++current_stage_;
   }
 }
 
 }  // namespace cc