Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: PRESUBMIT.py

Issue 775343004: Move //mojo/shell to //shell (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | mojo/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 except input_api.subprocess.CalledProcessError, error: 433 except input_api.subprocess.CalledProcessError, error:
434 return [output_api.PresubmitError( 434 return [output_api.PresubmitError(
435 'gn gen must not fail.', long_text=error.output)] 435 'gn gen must not fail.', long_text=error.output)]
436 436
437 # TODO(eseidel): Currently only these are known to pass, 437 # TODO(eseidel): Currently only these are known to pass,
438 # once everything passes we can just call 'gn check' once without a filter! 438 # once everything passes we can just call 'gn check' once without a filter!
439 KNOWN_PASSING = [ 439 KNOWN_PASSING = [
440 '//examples/*', 440 '//examples/*',
441 '//mojo/*', 441 '//mojo/*',
442 '//services/*', 442 '//services/*',
443 '//shell/*',
443 ] 444 ]
444 if input_api.platform != 'win32': 445 if input_api.platform != 'win32':
445 KNOWN_PASSING += [ 446 KNOWN_PASSING += [
446 '//sky/*', 447 '//sky/*',
447 ] 448 ]
448 for target_filter in KNOWN_PASSING: 449 for target_filter in KNOWN_PASSING:
449 try: 450 try:
450 input_api.subprocess.check_output(['gn', 'check', out_dir, 451 input_api.subprocess.check_output(['gn', 'check', out_dir,
451 target_filter]) 452 target_filter])
452 except input_api.subprocess.CalledProcessError, error: 453 except input_api.subprocess.CalledProcessError, error:
(...skipping 1141 matching lines...) Expand 10 before | Expand all | Expand 10 after
1594 builders = [ 1595 builders = [
1595 'Mojo Linux Try', 1596 'Mojo Linux Try',
1596 'Mojo Linux (dbg) Try', 1597 'Mojo Linux (dbg) Try',
1597 'Mojo Android Builder Try', 1598 'Mojo Android Builder Try',
1598 'Mojo Android Builder (dbg) Try', 1599 'Mojo Android Builder (dbg) Try',
1599 'Mojo ChromeOS Builder Try', 1600 'Mojo ChromeOS Builder Try',
1600 'Mojo ChromeOS Builder (dbg) Try', 1601 'Mojo ChromeOS Builder (dbg) Try',
1601 ] 1602 ]
1602 1603
1603 return GetDefaultTryConfigs(builders) 1604 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « DEPS ('k') | mojo/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698