Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: src/d8.cc

Issue 7753028: Print <undefined> in d8 when used as interactive shell. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 120496eccce5921f887eafadf6ebd71e59867edc..6ce7cd1625d99b6dd6887e8f23fd678c332436ff 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -172,7 +172,10 @@ bool Shell::ExecuteString(Handle<String> source,
return false;
} else {
ASSERT(!try_catch.HasCaught());
- if (print_result && !result->IsUndefined()) {
+ if (!print_result) return true;
+ if (result->IsUndefined()) {
+ printf("<undefined>\n");
+ } else {
// If all went well and the result wasn't undefined then print
// the returned value.
v8::String::Utf8Value str(result);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698