Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: tests/lib/mirrors/invocation_fuzz_test.dart

Issue 775223002: Remove several entries from invocation fuzzer blacklist. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/invocation_fuzz_test.dart
diff --git a/tests/lib/mirrors/invocation_fuzz_test.dart b/tests/lib/mirrors/invocation_fuzz_test.dart
index 975d1bce2198ce936a3eb51c0f10e48ccfbe9eb3..dadac59d26fd7f7f33e1f526698923b92a51718b 100644
--- a/tests/lib/mirrors/invocation_fuzz_test.dart
+++ b/tests/lib/mirrors/invocation_fuzz_test.dart
@@ -20,51 +20,40 @@ var blacklist = [
// Don't exit the test pre-maturely.
'dart.io.exit',
+ // Don't change the exit code, which may fool the test harness.
+ 'dart.io.exitCode',
+
// Don't run blocking io calls.
new RegExp(r".*Sync$"),
// These prevent the test from exiting.
- 'dart.async._scheduleAsyncCallback',
- 'dart.async._setTimerFactoryClosure',
- 'dart.isolate._startMainIsolate',
- 'dart.isolate._startIsolate',
'dart.io.sleep',
'dart.io.HttpServer.HttpServer.listenOn',
- new RegExp(r'dart.io.*'), /// smi: ok
+ new RegExp('dart\.io.*'), /// smi: ok
// Runtime exceptions we can't catch because they occur too early in event
// dispatch to be caught in a zone.
- 'dart.isolate._isolateScheduleImmediate',
'dart.io._Timer._createTimer', /// smi: ok
'dart.async.runZoned', /// string: ok
- 'dart.async._AsyncRun._scheduleImmediate',
'dart.async._ScheduleImmediate._closure',
- 'dart.async._asyncRunCallback',
- 'dart.async._rootHandleUncaughtError',
- 'dart.async._schedulePriorityAsyncCallback',
- 'dart.async._setScheduleImmediateClosure',
// These either cause the VM to segfault or throw uncatchable API errors.
// TODO(15274): Fix them and remove from blacklist.
'dart.io._IOService.dispatch',
- new RegExp(r'.*_RandomAccessFile.*'),
'dart.io._StdIOUtils._socketType',
'dart.io._StdIOUtils._getStdioOutputStream',
'dart.io._Filter.newZLibInflateFilter',
'dart.io._Filter.newZLibDeflateFilter',
'dart.io._FileSystemWatcher._listenOnSocket',
- 'dart.io.SystemEncoding.decode',
- 'dart.io.SystemEncoding.encode',
- 'dart.core.StringBuffer.toString', /// emptyarray: ok
-
- // See Object_toString and Issue 20583
- 'dart.core.Error._objectToString', /// string: ok
];
bool isBlacklisted(Symbol qualifiedSymbol) {
var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
for (var pattern in blacklist) {
- if (qualifiedString.contains(pattern)) return true;
+ if (qualifiedString.contains(pattern)) {
+ print('Skipping $qualifiedString');
+ return true;
+ }
}
return false;
}
@@ -168,18 +157,20 @@ doOneTask() {
var fuzzArgument;
-main([args]) {
+main() {
fuzzArgument = null;
fuzzArgument = 1; /// smi: ok
fuzzArgument = false; /// false: ok
fuzzArgument = 'string'; /// string: ok
fuzzArgument = new List(0); /// emptyarray: ok
+ print('Fuzzing with $fuzzArgument');
+
currentMirrorSystem().libraries.values.forEach(checkLibrary);
var valueObjects =
- [true, false, null,
- 0, 0xEFFFFFF, 0xFFFFFFFF, 0xFFFFFFFFFFFFFFFF,
+ [true, false, null, [], {}, dynamic,
+ 0, 0xEFFFFFF, 0xFFFFFFFF, 0xFFFFFFFFFFFFFFFF, 3.14159,
"foo", 'blåbærgrød', 'Îñţérñåţîöñåļîžåţîờñ', "𝄞", #symbol];
valueObjects.forEach((v) => checkInstance(reflect(v), 'value object'));
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698