Google Now Extension Auto Download

Google Now Extension Auto Download

Added support to download a finch guided extension for CrOS builds
with the app list extension build bit enabled.

BUG=457335
Committed: https://crrev.com/aa885bd74d2397fd514774c3e662f19063985759
Cr-Commit-Position: refs/heads/master@{#316334}

[robliao, 2014-12-10 18:38:56]

Here's how to do the AutoDownload restricted to CrOS in case it's needed while
I'm gone.

[robliao, 2015-02-10 19:03:04]

robliao@chromium.org changed reviewers:
+ skare@chromium.org

[skare_, 2015-02-10 19:09:56]

lgtm

[robliao, 2015-02-10 19:16:59]

robliao@chromium.org changed reviewers:
+ skare_;mgiuca@chromium.org
- skare@chromium.org

[robliao, 2015-02-10 19:18:09]

robliao@chromium.org changed reviewers:
+ benwells@chromium.org, mgiuca@chromium.org, skare@chromium.org
- skare_;mgiuca@chromium.org

[robliao, 2015-02-10 19:18:23]

robliao@chromium.org changed reviewers:
- benwells@chromium.org

[robliao, 2015-02-10 19:18:34]

robliao@chromium.org changed reviewers:
+ benwells@chromium.org

[robliao, 2015-02-10 19:20:10]

Adding mgiuca and benwells for OWNER approval.

mgiuca:
  chrome/browser/ui/app_list/app_list_extension.h
  chrome/browser/ui/app_list/app_list_extension.cc

benwells: 
  chrome/browser/extensions/external_component_loader.cc

[benwells, 2015-02-10 21:46:33]

I'm sorry I don't understand what this is for at all and the bug doesn't provide
much information. Could you update the bug to make it clearer what it's for?

[benwells, 2015-02-10 22:34:01]

c/b/e lgtm

https://codereview.chromium.org/775193003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/external_component_loader.cc (right):

https://codereview.chromium.org/775193003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/external_component_loader.cc:24: #if
defined(ENABLE_APP_LIST) && defined(OS_CHROMEOS)
I think this can just be #if defined(OS_CHROMEOS).

[robliao, 2015-02-10 22:37:53]

https://codereview.chromium.org/775193003/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/external_component_loader.cc (right):

https://codereview.chromium.org/775193003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/external_component_loader.cc:24: #if
defined(ENABLE_APP_LIST) && defined(OS_CHROMEOS)
On 2015/02/10 22:34:01, benwells wrote:
> I think this can just be #if defined(OS_CHROMEOS).

We're still gated by the gyp file with regards to ENABLE_APP_LIST, so for
correctness this needs to be here.

[robliao, 2015-02-12 22:15:09]

New patchsets have been uploaded after l-g-t-m from
skare@chromium.org,benwells@chromium.org

[robliao, 2015-02-12 22:16:53]

Applied requested renames.

[skare_, 2015-02-13 04:36:10]

lgtm

re-lgtm for new patchset 
(bit seems to have stuck, just got the 'stuff changed' mail)

[robliao, 2015-02-13 19:10:50]

We'd like to get this in before the next dev cut. Any remaining issues?

[robliao, 2015-02-13 23:05:26]

robliao@chromium.org changed reviewers:
+ xiyuan@chromium.org

[robliao, 2015-02-13 23:05:26]

Adding xiyuan since Australia is off for the weekend.

Can you provide owner approval for...
chrome/browser/ui/app_list/google_now_extension.cc
chrome/browser/ui/app_list/google_now_extension.h

Thanks!

[xiyuan, 2015-02-13 23:10:23]

lgtm

[robliao, 2015-02-13 23:13:15]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2015-02-13 23:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775193003/60001

[commit-bot: I haz the power, 2015-02-14 00:01:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-14 00:02:31]

Patchset 4 (id:??) landed as
https://crrev.com/aa885bd74d2397fd514774c3e662f19063985759
Cr-Commit-Position: refs/heads/master@{#316334}

[Matt Giuca, 2015-02-15 22:58:40]

lgtm