Fix PNaCl bitcode to LLVM IR reader to match new API.

Fix PNaCl bitcode to LLVM IR reader to match new API.

When LLVM 3.5 was merged, the handling of errors was broken. This
is being fixed in the CL listed below. This CL fixes Subzero's
call so that it will work with the CL listed below.

Relavant LLVM CL: https://codereview.chromium.org/770853002

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4006
R=jfb@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ae35f196bbc82e6fe7ccb2716368221d7a26476d

[Karl, 2014-12-03 18:42:17]

kschimpf@google.com changed reviewers:
+ jfb@chromium.org, jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-12-03 20:35:16]

LGTM modulo bikeshedding.

https://codereview.chromium.org/775173002/diff/1/src/llvm2ice.cpp
File src/llvm2ice.cpp (right):

https://codereview.chromium.org/775173002/diff/1/src/llvm2ice.cpp#newcode174
src/llvm2ice.cpp:174: cl::init(false));
I realize the default false value is consistent with the LLVM-side changes, but
why wouldn't we by default want more verbose, more awesome error messages?

[Karl, 2014-12-03 20:57:29]

https://codereview.chromium.org/775173002/diff/1/src/llvm2ice.cpp
File src/llvm2ice.cpp (right):

https://codereview.chromium.org/775173002/diff/1/src/llvm2ice.cpp#newcode174
src/llvm2ice.cpp:174: cl::init(false));
On 2014/12/03 20:35:15, stichnot wrote:
> I realize the default false value is consistent with the LLVM-side changes,
but
> why wouldn't we by default want more verbose, more awesome error messages?

I didn't worry about the verbose messages. Verbose messages give more detail
about the record that was bad. However, they do not give you a location within
the bitcode file (making it hard to find, even using pnacl-bcdis).

In addition, the use case in subzero for building LLVM IR is based on using
frozen valid LLVM IR. Hence, there shouldn't be any error messages in the first
place.

[JF, 2014-12-03 21:04:30]

lgtm

[Karl, 2014-12-03 22:50:01]

Committed patchset #1 (id:1) manually as
ae35f196bbc82e6fe7ccb2716368221d7a26476d (presubmit successful).