Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 775153003: Add codereview.settings to icu.git (Closed)

Created:
6 years ago by jungshik at Google
Modified:
6 years ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Visibility:
Public.

Description

Add codereview.settings to icu.git Add codereview.settings with the default values so that accepting default values in 'git cl config' works. BUG=438401 TEST=NONE R=vadimsh@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/53ecf0f68b27a004bef5526553b8e5f6c235b80b

Patch Set 1 #

Total comments: 1

Patch Set 2 : vc url fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
A codereview.settings View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jungshik at Google
Hi, can you take a look? I'm using this CL as a test a new ...
6 years ago (2014-12-03 21:24:05 UTC) #2
Vadim Sh.
lgtm with correction to VIEW_VC https://codereview.chromium.org/775153003/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/775153003/diff/1/codereview.settings#newcode3 codereview.settings:3: VIEW_VC: https://chromium.googlesource.com/chromium/deps/icu/ https://chromium.googlesource.com/chromium/deps/icu/+/
6 years ago (2014-12-03 21:45:33 UTC) #3
jungshik at Google
On 2014/12/03 21:45:33, Vadim Sh. wrote: > lgtm with correction to VIEW_VC > > https://codereview.chromium.org/775153003/diff/1/codereview.settings ...
6 years ago (2014-12-04 00:27:29 UTC) #4
jungshik at Google
6 years ago (2014-12-04 00:28:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
53ecf0f68b27a004bef5526553b8e5f6c235b80b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698