cc: Implement unified BeginFrame on aura

content/browser/compositor/delegated_frame_host.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_COMPOSITOR_DELEGATED_FRAME_HOST_H_
 #define CONTENT_BROWSER_COMPOSITOR_DELEGATED_FRAME_HOST_H_
 
 #include "cc/layers/delegated_frame_provider.h"
 #include "cc/layers/delegated_frame_resource_collection.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/surfaces/surface_factory_client.h"
 #include "content/browser/compositor/image_transport_factory.h"
 #include "content/browser/compositor/owned_mailbox.h"
 #include "content/browser/renderer_host/delegated_frame_evictor.h"
 #include "content/browser/renderer_host/dip_util.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/public/browser/render_process_host.h"
+#include "ui/base/compositor/compositor_begin_frame_observer.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/compositor_observer.h"
 #include "ui/compositor/compositor_vsync_manager.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_owner_delegate.h"
 #include "ui/gfx/rect_conversions.h"
 
 namespace cc {
 class SurfaceFactory;
+struct BeginFrameArgs;
 }
 
 namespace media {
 class VideoFrame;
 }
 
 namespace content {
 
 class DelegatedFrameHost;
 class ReadbackYUVInterface;
@@ skipping 19 matching lines @@
   virtual float CurrentDeviceScaleFactor() = 0;
   virtual gfx::Size ConvertViewSizeToPixel(const gfx::Size& size) = 0;
 
   // These are to be overridden for testing only.
   // TODO(ccameron): This is convoluted. Make the tests that need to override
   // these functions test DelegatedFrameHost directly (rather than do it
   // through RenderWidgetHostViewAura).
   virtual DelegatedFrameHost* GetDelegatedFrameHost() const = 0;
   virtual bool ShouldCreateResizeLock();
   virtual void RequestCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request);
+
+  virtual void OnSendBeginFrame(const cc::BeginFrameArgs& args) = 0;
 };
 
 // The DelegatedFrameHost is used to host all of the RenderWidgetHostView state
 // and functionality that is associated with delegated frames being sent from
 // the RenderWidget. The DelegatedFrameHost will push these changes through to
 // the ui::Compositor associated with its DelegatedFrameHostClient.
 class CONTENT_EXPORT DelegatedFrameHost
     : public ui::CompositorObserver,
+      public ui::CompositorBeginFrameObserver,
       public ui::CompositorVSyncManager::Observer,
       public ui::LayerOwnerDelegate,
       public ImageTransportFactoryObserver,
       public DelegatedFrameEvictorClient,
       public cc::DelegatedFrameResourceCollectionClient,
       public cc::SurfaceFactoryClient,
       public base::SupportsWeakPtr<DelegatedFrameHost> {
  public:
   DelegatedFrameHost(DelegatedFrameHostClient* client);
   ~DelegatedFrameHost() override;
@@ skipping 20 matching lines @@
   void CopyFromCompositingSurfaceToVideoFrame(
       const gfx::Rect& src_subrect,
       const scoped_refptr<media::VideoFrame>& target,
       const base::Callback<void(bool)>& callback);
   bool CanCopyToVideoFrame() const;
   bool CanSubscribeFrame() const;
   void BeginFrameSubscription(
       scoped_ptr<RenderWidgetHostViewFrameSubscriber> subscriber);
   void EndFrameSubscription();
   bool HasFrameSubscriber() const { return frame_subscriber_; }
+  void OnSetNeedsBeginFrames(bool needs_begin_frames);
 
   // Exposed for tests.
   cc::DelegatedFrameProvider* FrameProviderForTesting() const {
     return frame_provider_.get();
   }
   cc::SurfaceId SurfaceIdForTesting() const { return surface_id_; }
   void OnCompositingDidCommitForTesting(ui::Compositor* compositor) {
     OnCompositingDidCommit(compositor);
   }
   bool ShouldCreateResizeLockForTesting() { return ShouldCreateResizeLock(); }
@@ skipping 12 matching lines @@
 
   RenderWidgetHostViewFrameSubscriber* frame_subscriber() const {
     return frame_subscriber_.get();
   }
   bool ShouldCreateResizeLock();
   void RequestCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request);
 
   void LockResources();
   void UnlockResources();
 
+  void StartObservingBeginFrames();
+  void StopObservingBeginFrames();
+
+  void SetVSyncParams(base::TimeTicks timebase, base::TimeDelta interval);
+
   // Overridden from ui::CompositorObserver:
   void OnCompositingDidCommit(ui::Compositor* compositor) override;
   void OnCompositingStarted(ui::Compositor* compositor,
                             base::TimeTicks start_time) override;
   void OnCompositingEnded(ui::Compositor* compositor) override;
   void OnCompositingAborted(ui::Compositor* compositor) override;
   void OnCompositingLockStateChanged(ui::Compositor* compositor) override;
 
+  // Overridden from ui::CompositorBeginFrameObserver:
+  void OnSendBeginFrame(const cc::BeginFrameArgs& args) override;
+
   // Overridden from ui::CompositorVSyncManager::Observer:
   void OnUpdateVSyncParameters(base::TimeTicks timebase,
                                base::TimeDelta interval) override;
 
   // Overridden from ui::LayerOwnerObserver:
   void OnLayerRecreated(ui::Layer* old_layer, ui::Layer* new_layer) override;
 
   // Overridden from ImageTransportFactoryObserver:
   void OnLostResources() override;
 
@@ skipping 135 matching lines @@
 
   // Subscriber that listens to frame presentation events.
   scoped_ptr<RenderWidgetHostViewFrameSubscriber> frame_subscriber_;
   std::vector<scoped_refptr<OwnedMailbox> > idle_frame_subscriber_textures_;
 
   // YUV readback pipeline.
   scoped_ptr<content::ReadbackYUVInterface>
       yuv_readback_pipeline_;
 
   scoped_ptr<DelegatedFrameEvictor> delegated_frame_evictor_;
+
+  // True when unified BeginFrame scheduing is used.
+  bool begin_frame_scheduling_enabled_;
+
+  // True when RenderWidget needs a BeginFrame.
+  bool needs_begin_frames_;
+
+  // Pass |last_begin_frame_args_| to compositor when |this| is added as a
+  // CompositorBeginFrameObserver. With this, Compositor can determine whether
+  // latest BeginFrameArgs can be used immediately or not.
+  cc::BeginFrameArgs last_begin_frame_args_;

[brianderson, 2014/12/12 01:17:02]

last_sent_begin_frame_args_?

[simonhong, 2014/12/15 15:37:27]

Yep, it is more clear!

 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_COMPOSITOR_DELEGATED_FRAME_HOST_H_