ui/base/compositor/compositor_begin_frame_observer.h - Issue 775143003: cc: Implement unified BeginFrame on aura

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/compositor/compositor_begin_frame_observer.h

Issue 775143003: cc: Implement unified BeginFrame on aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move common logic to DelegatedFrameHost Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_BASE_COMPOSITOR_COMPOSITOR_BEGIN_FRAME_OBSERVER_H_

	6 #define UI_BASE_COMPOSITOR_COMPOSITOR_BEGIN_FRAME_OBSERVER_H_

	7

	8 namespace cc {

	9 struct BeginFrameArgs;

	10 }

	11

	12 namespace ui {

	13

	14 class CompositorBeginFrameObserver {
	brianderson 2014/12/09 03:00:31 Do we need this now that we have cc::BeginFrameObs Do we need this now that we have cc::BeginFrameObserver? simonhong 2014/12/09 17:09:27 IMO, both are doing different role and living in d Show quoted text On 2014/12/09 03:00:31, brianderson wrote: > Do we need this now that we have cc::BeginFrameObserver? IMO, both are doing different role and living in different layer although they have a similar interface. This is for *sending" BeginFrame where as cc::BeginFrameObserver::OnBeginFrame is for starting new BeginFrame.
	15 public:

	16 virtual ~CompositorBeginFrameObserver() {}

	17

	18 virtual void OnSendBeginFrame(const cc::BeginFrameArgs& args) = 0;

	19 };

	20

	21 } // namespace ui

	22

	23 #endif // UI_BASE_COMPOSITOR_COMPOSITOR_BEGIN_FRAME_OBSERVER_H_

OLD	NEW