Issue 775073002: Make debugger not fail with webpages_playback script and multiple skp files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 775073002: Make debugger not fail with webpages_playback script and multiple skp files (Closed)

Created:
6 years ago by Kimmo Kinnunen

Modified:
6 years ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Make debugger not fail with webpages_playback script and multiple skp files The debugger accepts either a single skp or a directory as a parameter. The webpages_playback script used to pass multiple files using a '*' glob. Committed: https://skia.googlesource.com/skia/+/960fb50a1a7ac76fd51e22983812f26bfffa6d1e

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/skp/webpages_playback.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775073002/1

6 years ago (2014-12-03 14:08:52 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-03 14:18:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/960fb50a1a7ac76fd51e22983812f26bfffa6d1e

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages