sky/engine/core/css/CSSStyleSheet.cpp - Issue 774953002: Always Reconstruct when stylesheets change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/CSSStyleSheet.cpp

Issue 774953002: Always Reconstruct when stylesheets change. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/CSSStyleSheet.cpp

diff --git a/sky/engine/core/css/CSSStyleSheet.cpp b/sky/engine/core/css/CSSStyleSheet.cpp

index 00dcdcbfa9ed2db76f94775b475244a0f266e110..376aff1416b68a07a2740c238a19b83b5ed9cc32 100644

--- a/sky/engine/core/css/CSSStyleSheet.cpp

+++ b/sky/engine/core/css/CSSStyleSheet.cpp

@@ -163,10 +163,7 @@ void CSSStyleSheet::didMutate(StyleSheetUpdateType updateType)

if (!owner)

return;

- // Need FullStyleUpdate when insertRule or deleteRule,

- // because StyleSheetCollection::analyzeStyleSheetChange cannot detect partial rule update.

- StyleResolverUpdateMode updateMode = updateType != PartialRuleUpdate ? AnalyzedStyleUpdate : FullStyleUpdate;

- owner->modifiedStyleSheet(this, updateMode);

+ owner->modifiedStyleSheet(this);

}

void CSSStyleSheet::reattachChildRuleCSSOMWrappers()