Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 774943007: Two tweaks for asan builds (Closed)

Created:
6 years ago by sky
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Two tweaks for asan builds . Makes mojob.py --test pick up asan config from args.gn . Excludes run_mojo_python_bindings_tests.py from running under asan. BUG=438781, 438734 TEST=none R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/45966ecb31c5f3cb155cb4ad7f49a742556b328a

Patch Set 1 #

Total comments: 4

Patch Set 2 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M mojo/tools/get_test_list.py View 1 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/tools/mojob.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years ago (2014-12-03 22:01:58 UTC) #1
viettrungluu
https://codereview.chromium.org/774943007/diff/1/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (right): https://codereview.chromium.org/774943007/diff/1/mojo/tools/get_test_list.py#newcode102 mojo/tools/get_test_list.py:102: "python") and \ I read a Python style guide, ...
6 years ago (2014-12-03 22:15:59 UTC) #2
sky
https://codereview.chromium.org/774943007/diff/1/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (right): https://codereview.chromium.org/774943007/diff/1/mojo/tools/get_test_list.py#newcode102 mojo/tools/get_test_list.py:102: "python") and \ On 2014/12/03 22:15:59, viettrungluu wrote: > ...
6 years ago (2014-12-03 23:15:15 UTC) #3
viettrungluu
lgtm
6 years ago (2014-12-04 01:11:14 UTC) #4
sky
6 years ago (2014-12-04 04:28:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
45966ecb31c5f3cb155cb4ad7f49a742556b328a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698