Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: Source/bindings/core/v8/V8Initializer.cpp

Issue 774933008: Disable ASan instrumentation of V8Initializer::initializeWorker() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Initializer.cpp
diff --git a/Source/bindings/core/v8/V8Initializer.cpp b/Source/bindings/core/v8/V8Initializer.cpp
index 8b29c7083c80ca58616c425abed89460478dd10c..f39ca85c4e6ceb271a1d8a541d9f8058e7ce5463 100644
--- a/Source/bindings/core/v8/V8Initializer.cpp
+++ b/Source/bindings/core/v8/V8Initializer.cpp
@@ -52,6 +52,7 @@
#include "platform/EventDispatchForbiddenScope.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/TraceEvent.h"
+#include "platform/heap/AddressSanitizer.h"
#include "platform/scheduler/Scheduler.h"
#include "public/platform/Platform.h"
#include "wtf/RefPtr.h"
@@ -500,6 +501,10 @@ static void messageHandlerInWorker(v8::Handle<v8::Message> message, v8::Handle<v
static const int kWorkerMaxStackSize = 500 * 1024;
+// This function uses a local stack variable to determine the isolate's stack limit. AddressSanitizer may
+// relocate that local variable to a fake stack, which may lead to problems during JavaScript execution.
+// Therefore we disable AddressSanitizer for V8Initializer::initializeWorker().
+NO_SANITIZE_ADDRESS
void V8Initializer::initializeWorker(v8::Isolate* isolate)
{
initializeV8Common(isolate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698