Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 774933004: Prefix CommandLine usage with base namespace (Part 9: components) (Closed)

Created:
6 years ago by kkristof
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 9: components) Prefix all CommandLine usage in the components/ directory's following subdirectories: feedback, gcm_driver, google, infobars, invalidation, keyed_service, metrics, nacl, omnibox and os_crypt with the base:: namespace BUG=422426 Committed: https://crrev.com/b33617cb4d1eacfec6f06cc8dc42d096e236edd7 Cr-Commit-Position: refs/heads/master@{#306790}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -65 lines) Patch
M components/feedback/feedback_uploader_chrome.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/google/core/browser/google_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_util_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M components/infobars/core/infobar_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/invalidation/invalidation_service_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/p2p_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/ticl_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/keyed_service/content/browser_context_dependency_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_state_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_state_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_broker_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 10 chunks +20 lines, -18 lines 0 comments Download
M components/nacl/common/nacl_cmd_line.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/nacl/common/nacl_nonsfi_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/nacl/loader/nacl_helper_win_64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/zygote/nacl_fork_delegate_linux.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/omnibox/keyword_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/omnibox_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/os_crypt/os_crypt_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
kkristof
Please Look at this.
6 years ago (2014-12-03 16:32:09 UTC) #2
blundell
Why don't you just pick one of us :) ? In general, if you add ...
6 years ago (2014-12-03 16:33:55 UTC) #3
Cait (Slow)
LGTM after indentation nits are fixed. (also +1 to blundell@'s suggestion) https://codereview.chromium.org/774933004/diff/1/components/google/core/browser/google_util_unittest.cc File components/google/core/browser/google_util_unittest.cc (right): ...
6 years ago (2014-12-03 16:43:21 UTC) #4
kkristof
On 2014/12/03 16:33:55, blundell wrote: > Why don't you just pick one of us :) ...
6 years ago (2014-12-03 16:51:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774933004/20001
6 years ago (2014-12-04 08:54:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-04 09:54:44 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-04 09:55:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b33617cb4d1eacfec6f06cc8dc42d096e236edd7
Cr-Commit-Position: refs/heads/master@{#306790}

Powered by Google App Engine
This is Rietveld 408576698