|
|
Created:
6 years ago by Mark Seaborn Modified:
6 years ago CC:
chromium-reviews, bradn, Derek Schuff, David Yen, hamaji, jvoung - send to chromium..., native-client-reviews_googlegroups.com, petarj, bradnelson Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionNaCl: Update revision in DEPS, r14147 -> r14154
This pulls in the following Native Client changes:
r14148: (dschuff) PNaCl: Update LLVM/clang/binutils-x86 revision in pnacl/COMPONENT_REVISIONS
r14149: (hamaji) Update revision for PNaCl r14144->r14148
r14150: (petarj) Fix issue in DecodeEscaping() in debug_stub test
r14151: (mseaborn) Remove much of the unused parts of pnacl/build.sh
r14152: (bradnelson) Nest the pnacl section of untrusted.gypi to the same level.
r14153: (dyen) The cached results from toolchain_build should be deterministic.
r14154: (jvoung) Add options for base dir and redirecting files to IRT open resource and use it.
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk
Committed: https://crrev.com/42eb0eef6896901103f03c37c7e1fdd6e87eac5e
Cr-Commit-Position: refs/heads/master@{#306727}
Patch Set 1 #Messages
Total messages: 19 (7 generated)
mseaborn@chromium.org changed reviewers: + dschuff@chromium.org
Rolling an earlier version since there was a problem with r14158 (https://codereview.chromium.org/771223002/).
lgtm
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774883002/1
The CQ bit was unchecked by mseaborn@chromium.org
The CQ bit was checked by mseaborn@chromium.org
The CQ bit was unchecked by mseaborn@chromium.org
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774883002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42eb0eef6896901103f03c37c7e1fdd6e87eac5e Cr-Commit-Position: refs/heads/master@{#306727}
Message was sent while issue was closed.
Did this break the MSAN bot? http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20M...
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
To answer my own question, r14152 broke it.
Message was sent while issue was closed.
On 2014/12/04 02:40:40, Lei Zhang wrote: > To answer my own question, r14152 broke it. To repro locally: GYP_DEFINES="clang=1 component=static_library instrumented_libraries_jobs=10 msan=1 msan_track_origins=0 target_arch=x64 use_goma=1 use_instrumented_libraries=1" gclient runhooks ninja -C out/Debug libjingle_nacl
Message was sent while issue was closed.
Going to revert the roll to unbreak the MSAN bots.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/773383002/ by thestig@chromium.org. The reason for reverting is: Broke MSAN bots..
Message was sent while issue was closed.
On 2014/12/04 00:42:30, Lei Zhang wrote: > Did this break the MSAN bot? > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20M... For reference, the error was: FAILED: cd ../../third_party/libjingle; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Release/xyz --config-name Release -t ../../out/Release/gen/sdk/ --arch pnacl --build newlib_plib --name ../../out/Release/gen/tc_pnacl_newlib/lib/libjingle_nacl.a --objdir ../../out/Release/obj/third_party/libjingle/libjingle_nacl.gen/pnacl_newlib-pnacl/libjingle_nacl "--include-dirs=../../out/Release/gen/tc_pnacl_newlib/include ../.. \"../../out/Release/gen\" ./source ../ ../../native_client_sdk/src/libraries ../../native_client_sdk/src/libraries/nacl_io/include ../../native_client_sdk/src/libraries/third_party/newlib-extras ../expat/files/lib ../boringssl/src/include" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror -gline-tables-only -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function " --gomadir /mnt/data/b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_DEFAULT_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS \"_FILE_OFFSET_BITS=64\" NO_TCMALLOC CHROMIUM_BUILD \"CR_CLANG_REVISION=218707\" \"TOOLKIT_VIEWS=1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"USE_CLIPBOARD_AURAX11=1\" ENABLE_ONE_CLICK_SIGNIN ENABLE_PRE_SYNC_BACKUP \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS USE_UDEV DONT_EMBED_BUILD_METADATA \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_PRINTING=1\" \"ENABLE_BASIC_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" \"ENABLE_LOAD_COMPLETION_HACKS=1\" V8_USE_EXTERNAL_STARTUP_DATA EXPAT_RELATIVE_PATH FEATURE_ENABLE_SSL GTEST_RELATIVE_PATH HAVE_OPENSSL_SSL_H NO_MAIN_THREAD_WRAPPING NO_SOUND_SYSTEM POSIX WEBRTC_POSIX SRTP_RELATIVE_PATH SSL_USE_OPENSSL USE_WEBRTC_DEV_BRANCH \"timezone=_timezone\" XML_STATIC \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_OPENSSL_CERTS=1\" MEMORY_TOOL_REPLACES_ALLOCATOR MEMORY_SANITIZER_INITIAL_SIZE MEMORY_SANITIZER" "--link_flags=-B../../out/Release/gen/tc_pnacl_newlib/lib " "--source-list=../../out/gypfiles/third_party/libjingle/pnacl_newlib.libjingle_nacl.source_list.gypcmd" ../webrtc/base/physicalsocketserver.cc:18:10: fatal error: 'sanitizer/msan_interface.h' file not found #include <sanitizer/msan_interface.h> ^ 1 error generated. (http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20M...) (BTW, please always copy+paste the relevant error for reference, because Buildbot URLs have a limited lifetime.) |