Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: runtime/vm/compiler.cc

Issue 774763002: Cleanups. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/block_scheduler.cc ('k') | runtime/vm/flow_graph.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 42068)
+++ runtime/vm/compiler.cc (working copy)
@@ -138,7 +138,7 @@
NULL, // NULL = not inlining.
osr_id);
- return new(isolate_) FlowGraph(builder,
+ return new(isolate_) FlowGraph(parsed_function,
result.graph_entry,
result.num_blocks);
}
@@ -425,8 +425,11 @@
osr_id);
}
- if (FLAG_print_flow_graph ||
- (optimized && FLAG_print_flow_graph_optimized)) {
+ const bool print_flow_graph =
+ FLAG_print_flow_graph ||
+ (optimized && FLAG_print_flow_graph_optimized);
+
+ if (print_flow_graph) {
if (osr_id == Isolate::kNoDeoptId) {
FlowGraphPrinter::PrintGraph("Before Optimizations", flow_graph);
} else {
@@ -448,7 +451,7 @@
// Transform to SSA (virtual register 0 and no inlining arguments).
flow_graph->ComputeSSA(0, NULL);
DEBUG_ASSERT(flow_graph->VerifyUseLists());
- if (FLAG_print_flow_graph || FLAG_print_flow_graph_optimized) {
+ if (print_flow_graph) {
FlowGraphPrinter::PrintGraph("After SSA", flow_graph);
}
}
@@ -667,7 +670,7 @@
allocator.AllocateRegisters();
if (reorder_blocks) block_scheduler.ReorderBlocks();
- if (FLAG_print_flow_graph || FLAG_print_flow_graph_optimized) {
+ if (print_flow_graph) {
FlowGraphPrinter::PrintGraph("After Optimizations", flow_graph);
}
}
« no previous file with comments | « runtime/vm/block_scheduler.cc ('k') | runtime/vm/flow_graph.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698