Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: runtime/vm/flow_graph_range_analysis.cc

Issue 774763002: Cleanups. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/il_printer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_range_analysis.h" 5 #include "vm/flow_graph_range_analysis.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/il_printer.h" 8 #include "vm/il_printer.h"
9 9
10 namespace dart { 10 namespace dart {
(...skipping 1509 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 } 1520 }
1521 1521
1522 RangeAnalysis* range_analysis_; 1522 RangeAnalysis* range_analysis_;
1523 FlowGraph* flow_graph_; 1523 FlowGraph* flow_graph_;
1524 Scheduler scheduler_; 1524 Scheduler scheduler_;
1525 }; 1525 };
1526 1526
1527 1527
1528 void RangeAnalysis::EliminateRedundantBoundsChecks() { 1528 void RangeAnalysis::EliminateRedundantBoundsChecks() {
1529 if (FLAG_array_bounds_check_elimination) { 1529 if (FLAG_array_bounds_check_elimination) {
1530 const Function& function = flow_graph_->parsed_function().function(); 1530 const Function& function = flow_graph_->parsed_function()->function();
1531 const bool try_generalization = 1531 const bool try_generalization =
1532 function.allows_bounds_check_generalization(); 1532 function.allows_bounds_check_generalization();
1533 1533
1534 BoundsCheckGeneralizer generalizer(this, flow_graph_); 1534 BoundsCheckGeneralizer generalizer(this, flow_graph_);
1535 1535
1536 for (intptr_t i = 0; i < bounds_checks_.length(); i++) { 1536 for (intptr_t i = 0; i < bounds_checks_.length(); i++) {
1537 CheckArrayBoundInstr* check = bounds_checks_[i]; 1537 CheckArrayBoundInstr* check = bounds_checks_[i];
1538 RangeBoundary array_length = 1538 RangeBoundary array_length =
1539 RangeBoundary::FromDefinition(check->length()->definition()); 1539 RangeBoundary::FromDefinition(check->length()->definition());
1540 if (check->IsRedundant(array_length)) { 1540 if (check->IsRedundant(array_length)) {
(...skipping 1603 matching lines...) Expand 10 before | Expand all | Expand 10 after
3144 } 3144 }
3145 } while (CanonicalizeMaxBoundary(&max) || 3145 } while (CanonicalizeMaxBoundary(&max) ||
3146 CanonicalizeMinBoundary(&canonical_length)); 3146 CanonicalizeMinBoundary(&canonical_length));
3147 3147
3148 // Failed to prove that maximum is bounded with array length. 3148 // Failed to prove that maximum is bounded with array length.
3149 return false; 3149 return false;
3150 } 3150 }
3151 3151
3152 3152
3153 } // namespace dart 3153 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/il_printer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698