Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 774713003: colorwheelnative gm, to test that colors look right under all conditions. (Closed)

Created:
6 years ago by hal.canary
Modified:
6 years ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

colorwheelnative gm, to test that colors look right under all conditions. Motivation: colorwheel on pdf-native (MacOS coregraphics) reverses Blue and Red. I want to see if this has anything to do with image decoding. BUG=skia:3184 Committed: https://skia.googlesource.com/skia/+/5abbc420e36feb229ed3498d7482a79f089c0e35

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M gm/colorwheel.cpp View 1 chunk +22 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774713003/1
6 years ago (2014-12-02 16:04:08 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-02 16:04:09 UTC) #3
hal.canary
PTAL
6 years ago (2014-12-02 16:47:39 UTC) #5
scroggo
lgtm
6 years ago (2014-12-02 17:34:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5abbc420e36feb229ed3498d7482a79f089c0e35
6 years ago (2014-12-02 17:37:21 UTC) #7
scroggo
6 years ago (2014-12-02 17:45:57 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/774713003/diff/1/gm/colorwheel.cpp
File gm/colorwheel.cpp (right):

https://codereview.chromium.org/774713003/diff/1/gm/colorwheel.cpp#newcode59
gm/colorwheel.cpp:59: DEF_SIMPLE_GM(colorwheelnative, canvas, 128, 28) {
Might there be a more descriptive name?

https://codereview.chromium.org/774713003/diff/1/gm/colorwheel.cpp#newcode61
gm/colorwheel.cpp:61: paint.setTypeface(SkTypeface::CreateFromName("Arial",
SkTypeface::kBold));
Is there a particular reason you chose this font? Do we have any fonts that
would look the same across platforms?

Powered by Google App Engine
This is Rietveld 408576698