Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: mojo/public/c/system/types.h

Issue 774673003: Added MojoNewWait and MojoNewWaitMany, along with unit tests. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/c/system/types.h
diff --git a/mojo/public/c/system/types.h b/mojo/public/c/system/types.h
index 9b1eedca402af3b5f7ddba40535d25e90e5b6f49..c2bc5cf1daaa9332af2727ed7498d7e0e739d65b 100644
--- a/mojo/public/c/system/types.h
+++ b/mojo/public/c/system/types.h
@@ -165,7 +165,15 @@ const MojoHandleSignals MOJO_HANDLE_SIGNAL_PEER_CLOSED = 1 << 2;
#define MOJO_HANDLE_SIGNAL_PEER_CLOSED ((MojoHandleSignals)1 << 2)
#endif
-// TODO(vtl): Add out parameters with this to MojoWait/MojoWaitMany.
+// |MojoHandleSignalsState|: Returned by wait functions to indicate the
+// signaling state of handles. Members are as follows:
+// - |satisfied signals| Bitmask of signals that were satisfied at some time
viettrungluu 2014/12/02 17:24:56 nit: colon after "|satisfied_signals|"
jimbe 2014/12/02 19:21:19 Done.
+// before the call returned. This can include signals that were not
+// listed in |signals|.
viettrungluu 2014/12/02 17:24:56 Dangling reference to |signals|.
jimbe 2014/12/02 19:21:19 Done.
+// - |satisfiable signals| These are the signals that are possible to satisfy.
viettrungluu 2014/12/02 17:24:56 same nit as above
jimbe 2014/12/02 19:21:19 Done.
+// For example, if the return value was
+// |MOJO_RESULT_FAILED_PRECONDITION|, you can use this field to
+// determine which, if any, of the signals can still be satisfied.
// Note: This struct is not extensible (and only has 32-bit quantities), so it's
// 32-bit-aligned.
MOJO_STATIC_ASSERT(MOJO_ALIGNOF(int32_t) == 4, "int32_t has weird alignment");

Powered by Google App Engine
This is Rietveld 408576698