Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 774603002: Adding AX test for input-file and enabling ax test for HR tag. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding AX test for input-file and enabling ax test for HR tag. BUG=384723, 418486 Committed: https://crrev.com/a85036840b6d372634e0d902b95f08800052e624 Cr-Commit-Position: refs/heads/master@{#306786}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : exposing AXDescription on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/test/data/accessibility/hr.html View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/hr-expected-mac.txt View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/hr-expected-win.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/input-file.html View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/input-file-expected-android.txt View 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/input-file-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-file-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-12-03 16:39:57 UTC) #1
dmazzoni
lgtm
6 years ago (2014-12-04 08:27:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774603002/60001
6 years ago (2014-12-04 08:27:54 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-04 09:19:22 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-04 09:20:16 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a85036840b6d372634e0d902b95f08800052e624
Cr-Commit-Position: refs/heads/master@{#306786}

Powered by Google App Engine
This is Rietveld 408576698