content/shell/browser/layout_test/layout_test_content_browser_client.h - Issue 774573003: Start pulling away notification logic from ChromeContentBrowserClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_content_browser_client.h

Issue 774573003: Start pulling away notification logic from ChromeContentBrowserClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/platform_notification_service.h ('k') | content/shell/browser/layout_test/layout_test_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_content_browser_client.h

diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.h b/content/shell/browser/layout_test/layout_test_content_browser_client.h

index b7648014b1c1839628c21f0ba8f5111df20d232b..b0f0643756a9a985553afc68fcb69abd96b83d06 100644

--- a/content/shell/browser/layout_test/layout_test_content_browser_client.h

+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.h

@@ -23,7 +23,7 @@ class LayoutTestContentBrowserClient : public ShellContentBrowserClient {

LayoutTestBrowserContext* GetLayoutTestBrowserContext();

- // Will be lazily created when running layout tests.

+ // Implements the PlatformNotificationService interface.

LayoutTestNotificationManager* GetLayoutTestNotificationManager();

// ContentBrowserClient overrides.

@@ -35,16 +35,7 @@ class LayoutTestContentBrowserClient : public ShellContentBrowserClient {

const GURL& requesting_frame,

bool user_gesture,

const base::Callback<void(bool)>& result_callback) override;

- blink::WebNotificationPermission CheckDesktopNotificationPermission(

- const GURL& source_url,

- ResourceContext* context,

- int render_process_id) override;

- void ShowDesktopNotification(

- const ShowDesktopNotificationHostMsgParams& params,

- BrowserContext* browser_context,

- int render_process_id,

- scoped_ptr<DesktopNotificationDelegate> delegate,

- base::Closure* cancel_callback) override;

+ PlatformNotificationService* GetPlatformNotificationService() override;

private:

scoped_ptr<LayoutTestNotificationManager> layout_test_notification_manager_;