Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 774553002: Revert of Updates the mic icon status based on the device's audio state. (Closed)

Created:
6 years ago by Ken Russell (switch to Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, jennyz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Updates the mic icon status based on the device's audio state. (patchset #5 id:80001 of https://codereview.chromium.org/752253002/) Reason for revert: Caused assertion failures in debug Linux ChromiumOS browser_tests; see Issue 383624 for details. Original issue's description: > Updates the mic icon status based on the device's audio state. > > BUG=383624 > R=amistry@chromium.org, tapted@chromium.org, oshima@chromium.org > TEST=manually > > Committed: https://crrev.com/3f492b65105964526ca8dc5d6a66971c0a427cdd > Cr-Commit-Position: refs/heads/master@{#306296} TBR=amistry@chromium.org,tapted@chromium.org,oshima@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=383624 Committed: https://crrev.com/c029af72efe407ee80dac6c16e26edc922b3c066 Cr-Commit-Position: refs/heads/master@{#306329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -100 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_resource_manager.cc View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 8 chunks +2 lines, -68 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Updates the mic icon status based on the device's audio state.
6 years ago (2014-12-02 02:24:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774553002/1
6 years ago (2014-12-02 02:25:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 02:26:15 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-02 02:27:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c029af72efe407ee80dac6c16e26edc922b3c066
Cr-Commit-Position: refs/heads/master@{#306329}

Powered by Google App Engine
This is Rietveld 408576698