Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 774543003: Context menu items are not proper when right click on Image in Extension. (Closed)

Created:
6 years ago by Deepak
Modified:
6 years ago
Reviewers:
Yoyo Zhou, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Context menu items are not proper when right click on Image in Extension. This is follow up change to add ITEM_GROUP_MEDIA_IMAGE so that we will get proper context menu for Image also. BUG=438091 Committed: https://crrev.com/d08566f23f1577fc63429345d88e362a8efe4b17 Cr-Commit-Position: refs/heads/master@{#306355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Deepak
This is followup changes for 372255 issue. I am adding case for Image, so that ...
6 years ago (2014-12-02 05:28:31 UTC) #2
lazyboy
lgtm
6 years ago (2014-12-02 06:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774543003/1
6 years ago (2014-12-02 06:31:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 10:40:14 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-02 10:41:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d08566f23f1577fc63429345d88e362a8efe4b17
Cr-Commit-Position: refs/heads/master@{#306355}

Powered by Google App Engine
This is Rietveld 408576698