Issue 77453009: Make auto-roll testable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77453009: Make auto-roll testable. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach

Modified:
7 years, 1 month ago

Reviewers:
ulan

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Make auto-roll testable. Refactor the mock code for easier reuse. Mock out web requests. TEST=python -m unittest test_scripts BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17987

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -69 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View		4 chunks	+14 lines, -19 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1	16 chunks	+122 lines, -50 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

7 years, 1 month ago (2013-11-22 07:56:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17987 (presubmit successful).